From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org,
rafael@kernel.org
Cc: linux-pm@vger.kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com
Subject: [PATCH 2/5] thermal: gov_power_allocator: Refactor check_power_actors()
Date: Wed, 6 Dec 2023 11:31:35 +0000 [thread overview]
Message-ID: <20231206113138.3576492-3-lukasz.luba@arm.com> (raw)
In-Reply-To: <20231206113138.3576492-1-lukasz.luba@arm.com>
Refactor check_power_actors() to make it possible for re-use in the
upcoming new callback.
No intentional functional impact.
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
drivers/thermal/gov_power_allocator.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
index 785fff14223d..38e1e89ba10c 100644
--- a/drivers/thermal/gov_power_allocator.c
+++ b/drivers/thermal/gov_power_allocator.c
@@ -581,8 +581,9 @@ static void allow_maximum_power(struct thermal_zone_device *tz, bool update)
* power actor API. The warning should help to investigate the issue, which
* could be e.g. lack of Energy Model for a given device.
*
- * Return: 0 on success, -EINVAL if any cooling device does not implement
- * the power actor API.
+ * Return number of cooling devices or -EINVAL if any cooling device does not
+ * implement the power actor API. Return value 0 is also valid since cooling
+ * devices might be attached later.
*/
static int check_power_actors(struct thermal_zone_device *tz,
struct power_allocator_params *params)
@@ -597,8 +598,9 @@ static int check_power_actors(struct thermal_zone_device *tz,
if (!cdev_is_power_actor(instance->cdev)) {
dev_warn(&tz->device, "power_allocator: %s is not a power actor\n",
instance->cdev->type);
- ret = -EINVAL;
+ return -EINVAL;
}
+ ret++;
}
return ret;
@@ -631,7 +633,7 @@ static int power_allocator_bind(struct thermal_zone_device *tz)
}
ret = check_power_actors(tz, params);
- if (ret) {
+ if (ret < 0) {
dev_warn(&tz->device, "power_allocator: binding failed\n");
kfree(params);
return ret;
--
2.25.1
next prev parent reply other threads:[~2023-12-06 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 11:31 [PATCH 0/5] Add callback for cooling list update to speed-up IPA Lukasz Luba
2023-12-06 11:31 ` [PATCH 1/5] thermal: core: Add callback for governors with cooling instances change Lukasz Luba
2023-12-11 20:41 ` Rafael J. Wysocki
2023-12-12 8:36 ` Lukasz Luba
2023-12-06 11:31 ` Lukasz Luba [this message]
2023-12-20 14:07 ` [PATCH 2/5] thermal: gov_power_allocator: Refactor check_power_actors() Rafael J. Wysocki
2023-12-20 16:29 ` Lukasz Luba
2023-12-06 11:31 ` [PATCH 3/5] thermal: gov_power_allocator: Move memory allocation out of throttle() Lukasz Luba
2023-12-06 11:31 ` [PATCH 4/5] thermal: gov_power_allocator: Simplify checks for valid power actor Lukasz Luba
2023-12-06 11:31 ` [PATCH 5/5] thermal: gov_power_allocator: Refactor checks in divvy_up_power() Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206113138.3576492-3-lukasz.luba@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox