From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com,
linux-arm-kernel@lists.infradead.org, sboyd@kernel.org,
nm@ti.com, linux-samsung-soc@vger.kernel.org,
daniel.lezcano@linaro.org, rafael@kernel.org,
viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org,
alim.akhtar@samsung.com, m.szyprowski@samsung.com,
xuewen.yan94@gmail.com, mhiramat@kernel.org, qyousef@layalina.io,
wvw@google.com
Subject: [PATCH 2/2] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage
Date: Wed, 20 Dec 2023 11:03:39 +0000 [thread overview]
Message-ID: <20231220110339.1065505-3-lukasz.luba@arm.com> (raw)
In-Reply-To: <20231220110339.1065505-1-lukasz.luba@arm.com>
When the voltage for OPPs is adjusted there is a need to also update
Energy Model framework. The EM data contains power values which depend
on voltage values. The EM structure is used for thermal (IPA governor)
and in scheduler task placement (EAS) so it should reflect the real HW
model as best as possible to operate properly.
Based on data on Exynos5422 ASV tables the maximum power difference might
be ~29%. An Odroid-XU4 (with a random sample SoC in this chip lottery)
showed power difference for some OPPs ~20%. Therefore, it's worth to
update the EM.
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
drivers/soc/samsung/exynos-asv.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/samsung/exynos-asv.c b/drivers/soc/samsung/exynos-asv.c
index d60af8acc391..328f079423d6 100644
--- a/drivers/soc/samsung/exynos-asv.c
+++ b/drivers/soc/samsung/exynos-asv.c
@@ -97,9 +97,17 @@ static int exynos_asv_update_opps(struct exynos_asv *asv)
last_opp_table = opp_table;
ret = exynos_asv_update_cpu_opps(asv, cpu);
- if (ret < 0)
+ if (!ret) {
+ /*
+ * When the voltage for OPPs successfully
+ * changed, update the EM power values to
+ * reflect the reality and not use stale data
+ */
+ dev_pm_opp_of_update_em(cpu);
+ } else {
dev_err(asv->dev, "Couldn't udate OPPs for cpu%d\n",
cpuid);
+ }
}
dev_pm_opp_put_opp_table(opp_table);
--
2.25.1
prev parent reply other threads:[~2023-12-20 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 11:03 [RFC PATCH 0/2] Introduce runtime modifiable Energy Model Lukasz Luba
2023-12-20 11:03 ` [PATCH 1/2] OPP: Add API to update EM after adjustment of voltage for OPPs Lukasz Luba
2023-12-21 7:28 ` Xuewen Yan
2023-12-21 8:04 ` Lukasz Luba
2023-12-26 5:12 ` Viresh Kumar
2024-01-04 10:38 ` Lukasz Luba
2024-01-04 17:11 ` Dietmar Eggemann
2024-01-04 17:27 ` Lukasz Luba
2023-12-20 11:03 ` Lukasz Luba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220110339.1065505-3-lukasz.luba@arm.com \
--to=lukasz.luba@arm.com \
--cc=alim.akhtar@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mhiramat@kernel.org \
--cc=nm@ti.com \
--cc=qyousef@layalina.io \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=wvw@google.com \
--cc=xuewen.yan94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox