From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Di Shen <cindygm567@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Di Shen <di.shen@unisoc.com>,
daniel.lezcano@linaro.org, rui.zhang@intel.com,
lukasz.luba@arm.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, xuewen.yan@unisoc.com,
zhanglyra@gmail.com, orsonzhai@gmail.com
Subject: Re: [PATCH] thermal: core: export the governor register related API
Date: Fri, 29 Dec 2023 08:46:19 +0000 [thread overview]
Message-ID: <2023122922-stature-overlying-c63d@gregkh> (raw)
In-Reply-To: <CAHYJL4p9ocr1FsM_Oc-p-H=NzfVuU3=8NYBwSV8oi+_vNuVUPg@mail.gmail.com>
On Fri, Dec 29, 2023 at 12:30:10PM +0800, Di Shen wrote:
> Hi Rafael,
>
> On Fri, Dec 29, 2023 at 4:24 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Thu, Dec 28, 2023 at 11:39 AM Di Shen <di.shen@unisoc.com> wrote:
> > >
> > > To enable users to register their own thermal governor,
> >
> > Why would anyone want to do that?
> >
>
> On Android systems, due to GKI restrictions, vendors cannot modify the
> kernel, and
> vendor-specific changes must be loaded as modules, so export this symbol so that
> vendors can load their own specific governor.
Why not get the needed changes merged upstream properly instead? That's
why Android does not allow you to change the core kernel, they want you
to work upstream first.
Random symbol exports are not allowed without a user for obvious reasons
(and you don't want us to take these patches either.)
thanks,
greg k-h
prev parent reply other threads:[~2023-12-29 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 10:39 [PATCH] thermal: core: export the governor register related API Di Shen
2023-12-28 20:23 ` Rafael J. Wysocki
2023-12-29 4:30 ` Di Shen
2023-12-29 8:46 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023122922-stature-overlying-c63d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=cindygm567@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=di.shen@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=orsonzhai@gmail.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=xuewen.yan@unisoc.com \
--cc=zhanglyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox