* [PATCH 1/2] dt-bindings: cpufreq: Add big CPU supply
@ 2023-12-29 21:28 Nícolas F. R. A. Prado
2024-01-04 8:03 ` Krzysztof Kozlowski
2024-01-09 4:26 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Nícolas F. R. A. Prado @ 2023-12-29 21:28 UTC (permalink / raw)
To: Viresh Kumar, Rafael J . Wysocki
Cc: kernel, AngeloGioacchino Del Regno, Nícolas F. R. A. Prado,
Conor Dooley, Hector Yuan, Krzysztof Kozlowski, Matthias Brugger,
Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
linux-mediatek, linux-pm
The performance-controller hardware block on MediaTek SoCs is
responsible for controlling the frequency of the CPUs. As such, it needs
any CPU regulator to have been configured prior to initializing. Add a
phandle in the binding so this dependency can be described.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
.../devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
index d0aecde2b89b..d75b01d04998 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
@@ -33,6 +33,8 @@ properties:
performance domains.
const: 1
+ big-cpus-supply: true
+
required:
- compatible
- reg
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] dt-bindings: cpufreq: Add big CPU supply
2023-12-29 21:28 [PATCH 1/2] dt-bindings: cpufreq: Add big CPU supply Nícolas F. R. A. Prado
@ 2024-01-04 8:03 ` Krzysztof Kozlowski
2024-01-09 4:26 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-04 8:03 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Viresh Kumar, Rafael J . Wysocki
Cc: kernel, AngeloGioacchino Del Regno, Conor Dooley, Hector Yuan,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, linux-pm
On 29/12/2023 22:28, Nícolas F. R. A. Prado wrote:
> The performance-controller hardware block on MediaTek SoCs is
> responsible for controlling the frequency of the CPUs. As such, it needs
> any CPU regulator to have been configured prior to initializing. Add a
> phandle in the binding so this dependency can be described.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
>
> .../devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> index d0aecde2b89b..d75b01d04998 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> @@ -33,6 +33,8 @@ properties:
> performance domains.
> const: 1
>
> + big-cpus-supply: true
Why big? Neither little nor medium need power? Why you do not need to
provide all supplies?
About the naming, use something matching the devices, e.g. from their
datasheet/manual.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] dt-bindings: cpufreq: Add big CPU supply
2023-12-29 21:28 [PATCH 1/2] dt-bindings: cpufreq: Add big CPU supply Nícolas F. R. A. Prado
2024-01-04 8:03 ` Krzysztof Kozlowski
@ 2024-01-09 4:26 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2024-01-09 4:26 UTC (permalink / raw)
To: Nícolas F. R. A. Prado
Cc: Viresh Kumar, Rafael J . Wysocki, kernel,
AngeloGioacchino Del Regno, Conor Dooley, Hector Yuan,
Krzysztof Kozlowski, Matthias Brugger, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, linux-pm
On Fri, Dec 29, 2023 at 06:28:39PM -0300, Nícolas F. R. A. Prado wrote:
> The performance-controller hardware block on MediaTek SoCs is
> responsible for controlling the frequency of the CPUs. As such, it needs
> any CPU regulator to have been configured prior to initializing. Add a
> phandle in the binding so this dependency can be described.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
>
> .../devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> index d0aecde2b89b..d75b01d04998 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> @@ -33,6 +33,8 @@ properties:
> performance domains.
> const: 1
>
> + big-cpus-supply: true
> +
A CPU's supply belongs in the respective CPU nodes.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-09 4:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-29 21:28 [PATCH 1/2] dt-bindings: cpufreq: Add big CPU supply Nícolas F. R. A. Prado
2024-01-04 8:03 ` Krzysztof Kozlowski
2024-01-09 4:26 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).