From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 604CD125CA for ; Thu, 11 Jan 2024 10:00:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="AsEZXAkq" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a277339dcf4so566543966b.2 for ; Thu, 11 Jan 2024 02:00:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1704967214; x=1705572014; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SK6l91q7AEIn5ipGCEJlFPJF27Zw8+0MoPYYgQPY0a4=; b=AsEZXAkq7rgCb3FMKtxC+H3Axt8OhMzF2gp6HL3KglEpPC7pY7kHgjFG81lXzvZ/UN wLwIG5YIr1ReEYlGnn+d90k0CfdMpuxobTPyawzLSiaDcBaKeP2HJ4KQWiJS1XmMyJ39 k/Ox2Pc/agvuZh/X6kGyNAFogbRgembnxmEN5DN1il19f96KXjO0q4yMO2ZKT8wB+uhW Z3uuo40KyPsRHX0BL8uZd/DaWA7ZBygNYC0OOd8vcHNYPg/HzJKv+59yuLsDWAmdoXxO 9kD7Obb+S73Nur8WGtFBbObUn8GOEjpRCq5IgfVPGJJtdo1oBRyj4Jx1HvVklaXvws9N G1cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704967214; x=1705572014; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SK6l91q7AEIn5ipGCEJlFPJF27Zw8+0MoPYYgQPY0a4=; b=XT/LP5KN+xz74zahjlidhe1wZ/w+qEJ0hFlnfL+4hr576AH+yc2ZCeTLQsLENr9jMw LsREIL1fLzaLNd+SNb9fOfvODZEr0F5T67TVbQdb8ImJBO5ntBmfGtYGZUESxWBK/8IX w+rEgo1mvmkEefpuZxiDVXaaprnOGH1XK86uhoQSN1GdtY6um+AszndQOzddMM7YFEZ2 iGrOt9XumE3zlnPnFH22/lCOLhkOcYGJ1C6hxn6M3WxE3RiTKFOpsBHEAghKfg4PEkRb FLjUqil1Wl2BT0RY8Vj+O3h179/LGIuYJDGZFiSp4EXZ/cBp41eRCy0va78nHFrjktSW HZkA== X-Gm-Message-State: AOJu0YxMt0d221SQg7qgEswQBWMRn3/cF0Pjnbb3HMP1Eq1om7bPxY22 DDTXG6IyEDIbZ3km3r+WBZmRXmp7SMCq8Q== X-Google-Smtp-Source: AGHT+IG9OykZ6CNPvrkHEc3LhlxSvCDJTd22uv+2HGjZ6t7gDVg53BD9mWU36h/4tpDnSh7smSjEVg== X-Received: by 2002:a17:907:9281:b0:a27:f6aa:c7b0 with SMTP id bw1-20020a170907928100b00a27f6aac7b0mr576724ejc.11.1704967214471; Thu, 11 Jan 2024 02:00:14 -0800 (PST) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id o8-20020a170906358800b00a2ace215a78sm368912ejb.114.2024.01.11.02.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 02:00:13 -0800 (PST) Date: Thu, 11 Jan 2024 11:00:12 +0100 From: Andrew Jones To: Sunil V L Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org, "Rafael J . Wysocki" , Len Brown , Anup Patel , Daniel Lezcano , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Atish Kumar Patra Subject: Re: [PATCH -next 1/2] ACPI: Enable ACPI_PROCESSOR for RISC-V Message-ID: <20240111-bb411d2dd39eb859dd049fa0@orel> References: <20240111093058.121838-1-sunilvl@ventanamicro.com> <20240111093058.121838-2-sunilvl@ventanamicro.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111093058.121838-2-sunilvl@ventanamicro.com> On Thu, Jan 11, 2024 at 03:00:57PM +0530, Sunil V L wrote: > The ACPI processor driver is not currently enabled for RISC-V. > This is required to enable CPU related functionalities like > LPI and CPPC. Hence, enable ACPI_PROCESSOR for RISC-V. > > Signed-off-by: Sunil V L > --- > drivers/acpi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index f819e760ff19..9a920752171c 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -282,7 +282,7 @@ config ACPI_CPPC_LIB > > config ACPI_PROCESSOR > tristate "Processor" > - depends on X86 || ARM64 || LOONGARCH > + depends on X86 || ARM64 || LOONGARCH || RISCV > select ACPI_PROCESSOR_IDLE > select ACPI_CPU_FREQ_PSS if X86 || LOONGARCH > select THERMAL > -- > 2.34.1 > Hi Sunil, Typically we'll want the Kconfig changes to come at the end of a series, or squashed into the patch that adds support for it, otherwise there's risk of build breakage during bisection. In this case, we're safe because the two new functions (I looked ahead) have __weak versions when they're not present. Also, interestingly, it looks like this ancient line obj-$(CONFIG_ACPI_PROCESSOR) += processor.o in drivers/acpi/Makefile should be removed, since there's no drivers/acpi/processor.c file. I guess the make process silently filters object files which don't have corresponding source files? Maybe we should write a Makefile analyzer to see what other lines can be removed... Anyway, for this patch, which I'd prefer to be swapped in order with the other patch, or just squashed into the other patch, Reviewed-by: Andrew Jones Thanks, drew