Re: [PATCH 6/9] arm64: dts: mediatek: mt8186: add default thermal zones

Daniel Lezcano
2024-01-19T17:04:07Z

On 15/01/2024 18:52, Krzysztof Kozlowski wrote:
> On 15/01/2024 18:46, Nicolas Pitre wrote:
>>>> @@ -2115,4 +2117,238 @@ larb19: smi@1c10f000 {
>>>> power-domains = <&spm MT8186_POWER_DOMAIN_IPE>;
>>>> };
>>>> };
>>>> +
>>>> + thermal_zones: thermal-zones {
>>>> + cpu_zone0-thermal {
>>>
>>> No underscores in node names. Could one CPU have multiple names? If not,
>>> then it is just "cpu0-thermal".
>>
>> Well... I'm not completely clear about this given the available info,
>> but this thermal zone would not be matching a single CPU but a few of
>> them, hence several "zones of CPUs".
>
> OK, then just: cpu-zone0-thermal

Given the node name is used as the thermal zone name. The 'zone' is
duplicate in the namespace.

/sys/class/thermal/thermal_zone0/type = cpu-zone0-thermal

Furthermore, if other thermal zones are registered before, that could be:

/sys/class/thermal/thermal_zone4/type = cpu-zone0-thermal

Kind of inconsistent :/

If it is a group of CPUS, they are probably belonging to the same
performance domain, may be we can use the name 'cluster' here:

cluster0-thermal

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |