Linux Power Management development
 help / color / mirror / Atom feed
From: Aren Moynihan <aren@peacevolution.org>
To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Ondřej Jirman" <megi@xff.cz>,
	"Hans de Goede" <j.w.r.degoede@gmail.com>,
	"Aidan MacDonald" <aidanmacdonald.0x0@gmail.com>,
	"Aren Moynihan" <aren@peacevolution.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Quentin Schulz" <quentin.schulz@bootlin.com>,
	"Sebastian Reichel" <sre@kernel.org>
Subject: [PATCH v2 0/5] power: supply: axp20x_usb_power: cleanup input current limit handling
Date: Tue, 30 Jan 2024 15:27:56 -0500	[thread overview]
Message-ID: <20240130203714.3020464-1-aren@peacevolution.org> (raw)

Proper handling of the input current limit will be necessary to
implement usb power delivery on the Pine64 PinePhone. The PinePhone has
a separate chip (anx7688) that handles usb power delivery (among other
things), so we will need a way to apply the current limit which that
negotiates.

The new logic to get/set the input current limit, and get the usb type
is originally based on code Ondřej Jirman wrote[1], but I have
significantly refactored it.

While working on this, I also discovered that the axp803 pmic sets a
current limit of 3A on the usb port without any negotiation if it
doesn't detect a battery.

v1 of this patch can be found at:
https://lore.kernel.org/lkml/20240121014057.1042466-1-aren@peacevolution.org/

1: https://xff.cz/git/linux/commit/?h=axp-6.7&id=3dcd33dfd1ae58db159427365dcb6d0d2b12f06d

Changes in v2:
 - Values less than the lowest supported limit are rounded up instead
   of returning -EINVAL when setting the input current limit.
 - Rename existing current_max logic to input_current_limit. This also
   makes it possible to reuse some of that logic.
 - Split current limit register and bc race condition fixes into
   different commits.

Aren Moynihan (5):
  power: supply: axp20x_usb_power: replace current_max with
    input_current_limit
  power: supply: axp20x_usb_power: use correct register for input
    current limit
  power: supply: axp20x_usb_power: fix race condition with usb bc
  power: supply: axp20x_usb_power: enable usb_type reporting
  power: supply: axp20x_usb_power: set input current limit in probe

 drivers/power/supply/axp20x_usb_power.c | 160 +++++++++++++++++++++---
 1 file changed, 144 insertions(+), 16 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-01-30 20:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 20:27 Aren Moynihan [this message]
2024-01-30 20:27 ` [PATCH v2 1/5] power: supply: axp20x_usb_power: replace current_max with input_current_limit Aren Moynihan
2024-01-30 20:27 ` [PATCH v2 2/5] power: supply: axp20x_usb_power: use correct register for input current limit Aren Moynihan
2024-01-30 20:27 ` [PATCH v2 3/5] power: supply: axp20x_usb_power: fix race condition with usb bc Aren Moynihan
2024-01-30 20:28 ` [PATCH v2 4/5] power: supply: axp20x_usb_power: enable usb_type reporting Aren Moynihan
2024-01-30 20:28 ` [PATCH v2 5/5] power: supply: axp20x_usb_power: set input current limit in probe Aren Moynihan
2024-01-30 21:13   ` Ondřej Jirman
2024-01-31  4:20     ` Aren
2024-02-10 23:27       ` Ondřej Jirman
2024-03-14 22:39         ` Aren
2024-03-20  0:12           ` Ondřej Jirman
2024-03-23 21:36             ` Aren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240130203714.3020464-1-aren@peacevolution.org \
    --to=aren@peacevolution.org \
    --cc=aidanmacdonald.0x0@gmail.com \
    --cc=j.w.r.degoede@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=megi@xff.cz \
    --cc=quentin.schulz@bootlin.com \
    --cc=sre@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox