From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
bhelgaas@google.com, andriy.shevchenko@linux.intel.com,
stanislaw.gruszka@linux.intel.com, lukas@wunner.de,
rafael@kernel.org, ilpo.jarvinen@linux.intel.com,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
sashal@kernel.org
Subject: Re: [PATCH v1] PCI / PM: Really allow runtime PM without callback functions
Date: Mon, 26 Feb 2024 09:41:13 +0200 [thread overview]
Message-ID: <20240226074113.GZ8454@black.fi.intel.com> (raw)
In-Reply-To: <Zdw_SV81YfJvCx2I@black.fi.intel.com>
On Mon, Feb 26, 2024 at 09:35:37AM +0200, Raag Jadav wrote:
> On Wed, Feb 14, 2024 at 10:15:29PM +0200, Raag Jadav wrote:
> > On Wed, Feb 14, 2024 at 10:58:00AM -0600, Bjorn Helgaas wrote:
> > > On Wed, Feb 14, 2024 at 08:58:48AM +0200, Jarkko Nikula wrote:
> > > > On 2/13/24 22:06, Bjorn Helgaas wrote:
> > > > > > Debugged-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > > >
> > > > > Sounds like this resolves a problem report? Is there a URL we can
> > > > > cite? If not, at least a mention of what the user-visible problem is?
> > > > >
> > > > > From the c5eb1190074c commit log, it sounds like maybe this allows
> > > > > devices to be autosuspended when they previously could not be?
> > > > >
> > > > > Possibly this should have "Fixes: c5eb1190074c ("PCI / PM: Allow
> > > > > runtime PM without callback functions")" since it sounds like it goes
> > > > > with it?
> > > > >
> > > > I don't think there's known regression but my above commit wasn't complete.
> > > > Autosuspending works without runtime PM callback as long as the driver has
> > > > the PM callbacks structure set.
> > >
> > > I didn't suggest there was a regression, but if we mention that Mika
> > > debugged something, I want to know what the something was.
> >
> > Considering it's not a bug to begin with, perhaps we can change it to
> > Suggested-by or Co-developed-by?
>
> Hi Mika,
>
> If you are okay with this, please let me know and perhaps suggest a better
> fit for the scenario.
You can just drop my name from it completely.
next prev parent reply other threads:[~2024-02-26 7:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 6:32 [PATCH v1] PCI / PM: Really allow runtime PM without callback functions Raag Jadav
2024-02-13 14:02 ` Rafael J. Wysocki
2024-02-13 20:06 ` Bjorn Helgaas
2024-02-14 6:58 ` Jarkko Nikula
2024-02-14 16:58 ` Bjorn Helgaas
2024-02-14 20:15 ` Raag Jadav
2024-02-26 7:35 ` Raag Jadav
2024-02-26 7:41 ` Mika Westerberg [this message]
2024-02-14 10:43 ` Raag Jadav
2024-02-14 13:01 ` Andy Shevchenko
2024-02-14 13:20 ` Raag Jadav
2024-02-14 16:06 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226074113.GZ8454@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=raag.jadav@intel.com \
--cc=rafael@kernel.org \
--cc=sashal@kernel.org \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).