From: Dhruva Gole <d-gole@ti.com>
To: Saravana Kannan <saravanak@google.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
<kernel-team@android.com>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Documentation: power: Fix typo in suspend and interrupts doc
Date: Mon, 11 Mar 2024 10:09:27 +0530 [thread overview]
Message-ID: <20240311043927.il77znubaymo3rhd@dhruva> (raw)
In-Reply-To: <20240308224450.2327415-1-saravanak@google.com>
On Mar 08, 2024 at 14:44:50 -0800, Saravana Kannan wrote:
> Typos are bad. Fix them.
Maybe a little more description that you s/by/but would've also made
things more clear?
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
> Documentation/power/suspend-and-interrupts.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/power/suspend-and-interrupts.rst b/Documentation/power/suspend-and-interrupts.rst
> index dfbace2f4600..f588feeecad0 100644
> --- a/Documentation/power/suspend-and-interrupts.rst
> +++ b/Documentation/power/suspend-and-interrupts.rst
> @@ -78,7 +78,7 @@ handling the given IRQ as a system wakeup interrupt line and disable_irq_wake()
> turns that logic off.
>
> Calling enable_irq_wake() causes suspend_device_irqs() to treat the given IRQ
> -in a special way. Namely, the IRQ remains enabled, by on the first interrupt
> +in a special way. Namely, the IRQ remains enabled, but on the first interrupt
> it will be disabled, marked as pending and "suspended" so that it will be
> re-enabled by resume_device_irqs() during the subsequent system resume. Also
> the PM core is notified about the event which causes the system suspend in
> --
Anyway, changes LGTM!
Reviewed-by: Dhruva Gole <d-gole@ti.com>
--
Best regards,
Dhruva Gole <d-gole@ti.com>
next prev parent reply other threads:[~2024-03-11 4:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 22:44 [PATCH] Documentation: power: Fix typo in suspend and interrupts doc Saravana Kannan
2024-03-11 4:39 ` Dhruva Gole [this message]
2024-03-13 19:52 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311043927.il77znubaymo3rhd@dhruva \
--to=d-gole@ti.com \
--cc=kernel-team@android.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox