From: David McFarland <corngood@gmail.com>
To: linux-pm@vger.kernel.org
Cc: David McFarland <corngood@gmail.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: [PATCH 0/1] Failure to hibernate on Dell Latitude 7430
Date: Mon, 18 Mar 2024 16:11:51 -0300 [thread overview]
Message-ID: <20240318191153.6978-1-corngood@gmail.com> (raw)
I have a Dell Latitude 7430, and recently whenever I hibernate with
`systemctl hibernate`, the machine would immediately wake.
I bisected it to:
0c4cae1bc00d PM: hibernate: Avoid missing wakeup events during hibernation
However, the underlying problem seems to be that during hibernation, my
system gets a 0xcf (power button release) event, and the above change
causes it to abort hibernation correctly.
I also noticed that holding the power button down (when it's configured
to suspend) causes the system to suspend and then wake upon release, if
it's held long enough.
I'm attaching a patch which fixes the problem for me, by skipping the
wake on any of the release events. These events are all marked
KEY_IGNORE, so think this is a reasonable thing to do.
I'm a little worried about the consequences of doing this
unconditionally in intel-hid. Perhaps it should be a quirk?
David McFarland (1):
platform/x86/intel/hid: Don't wake on 5-button releases
drivers/platform/x86/intel/hid.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
--
2.42.0
next reply other threads:[~2024-03-18 19:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 19:11 David McFarland [this message]
2024-03-18 19:11 ` [PATCH 1/1] platform/x86/intel/hid: Don't wake on 5-button releases David McFarland
2024-03-29 13:51 ` Linux regression tracking (Thorsten Leemhuis)
2024-03-29 18:06 ` David McFarland
2024-03-30 6:54 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-01 15:36 ` Enrik Berkhan
2024-04-02 11:36 ` Hans de Goede
2024-04-04 11:41 ` [PATCH v2] " David McFarland
2024-04-04 18:35 ` Hans de Goede
2024-04-08 15:42 ` Ilpo Järvinen
2024-03-21 9:31 ` [PATCH 0/1] Failure to hibernate on Dell Latitude 7430 Linux regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318191153.6978-1-corngood@gmail.com \
--to=corngood@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).