From: Bjorn Helgaas <helgaas@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] Documentation: PM: Update platform_pci_wakeup_init() reference
Date: Wed, 27 Mar 2024 10:25:35 -0500 [thread overview]
Message-ID: <20240327152535.GA1523374@bhelgaas> (raw)
In-Reply-To: <CAJZ5v0j6SaxTG9+Zr1Sk9iN_bvzzOCD+7_s98HEes1CY825epQ@mail.gmail.com>
On Wed, Mar 27, 2024 at 04:23:41PM +0100, Rafael J. Wysocki wrote:
> On Mon, Mar 25, 2024 at 11:11 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > platform_pci_wakeup_init() was removed by d2e5f0c16ad6 ("ACPI / PCI: Rework
> > the setup and cleanup of device wakeup") but was still mentioned in the
> > documentation.
> >
> > Update the doc to refer to pci_acpi_setup(), which does the equivalent
> > work.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > ---
> >
> > pci_acpi_setup() is a firmware-specific wart in this otherwise generic
> > paragraph, so maybe there's some better way to express this?
> >
> > Documentation/power/pci.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/power/pci.rst b/Documentation/power/pci.rst
> > index 12070320307e..e2c1fb8a569a 100644
> > --- a/Documentation/power/pci.rst
> > +++ b/Documentation/power/pci.rst
> > @@ -333,7 +333,7 @@ struct pci_dev.
> > The PCI subsystem's first task related to device power management is to
> > prepare the device for power management and initialize the fields of struct
> > pci_dev used for this purpose. This happens in two functions defined in
> > -drivers/pci/pci.c, pci_pm_init() and platform_pci_wakeup_init().
> > +drivers/pci/, pci_pm_init() and pci_acpi_setup().
> >
> > The first of these functions checks if the device supports native PCI PM
> > and if that's the case the offset of its power management capability structure
> > --
>
> Applied as 6.10 material, or if you'd rather take it to the PCI tree,
> please let me know.
Thanks, your tree is fine!
Bjorn
prev parent reply other threads:[~2024-03-27 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 22:09 [PATCH] Documentation: PM: Update platform_pci_wakeup_init() reference Bjorn Helgaas
2024-03-26 4:53 ` Dhruva Gole
2024-03-27 15:23 ` Rafael J. Wysocki
2024-03-27 15:25 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327152535.GA1523374@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox