Re: [PATCH v2 1/4] dt-bindings: power: reset: Convert mode-.* properties to array

Krzysztof Kozlowski
2024-04-20T10:57:47Z

On 14/04/2024 21:30, Elliot Berman wrote:
> PSCI reboot mode will map a mode name to multiple magic values instead
> of just one. Convert the mode-.* property to an array. Users of the
> reboot-mode schema will need to specify the maxItems of the mode-.*
> properties. Existing users will all be 1.
>
> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> ---
> .../devicetree/bindings/power/reset/nvmem-reboot-mode.yaml | 4 ++++
> Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 4 ++++
> .../devicetree/bindings/power/reset/reboot-mode.yaml | 12 ++++++++++--
> .../devicetree/bindings/power/reset/syscon-reboot-mode.yaml | 4 ++++
> 4 files changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> index 627f8a6078c2..03b3b9be36de 100644
> --- a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> @@ -30,6 +30,10 @@ properties:
>
> allOf:
> - $ref: reboot-mode.yaml#
> + - patternProperties:
> + "^mode-.*$":
> + items:
> + maxItems: 1

You still need to limit total number of items. This only defines how
many items you have in each inner cell of the matrix. What about the
other cell?

I understood that you want something more or less equivalent, but the
code does not look like.

Best regards,
Krzysztof