Re: [PATCH v9 0/7] KTD2026 indicator LED for X86 Xiaomi Pad2

[Lee Jones <lee@kernel.org>]

On Sat, 04 May 2024, Hans de Goede wrote:

> Hi All,
> 
> Here is v9 of Kate's series to add support for Xiaomi Pad2 indicator LED.
> 
> I believe this is ready for merging now. Patch 6/7 has an Acked-by from
> Sebastien for merging this patch through the leds tree since it depends
> on the earlier patches. LEDs tree maintainers please merge patches 1-6,
> then patch 7 can be merged through the pdx86 tree independently.
> 
> This applies on top of:
> git://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git ib-leds-locking-v6.10
> 
> This work includes:
> 1. Added the KTD2026 swnode description to describe the LED controller.
> 2. Migrated the original driver to fwnode to support x86 platform.
> 3. Support for multi-color LED trigger events.
> 4. The LED shows orange when charging and the LED shows green when the
>    battery is full.
> 
> Moreover, the LED trigger is set to the new trigger, called
> "bq27520-0-charging-orange-full-green" for Xiaomi Pad2 so the LED shows
> orange when charging and the LED shows green when the battery is full.
> 
> --
> Changes in v9:
> 1. Switch to devm_mutex_init()
> 2. Add Andy's Reviewed-by to the series
> 
> Changes in v8:
> 1. New bugfix: "leds: rgb: leds-ktd202x: Initialize mutex earlier"
> 2. Make charging_orange_full_green triggers set the colors in RGB order
> 3. Modify the Pad2 ktd202x fwnode to have the colors in RGB order
> 
> Changes in v7:
> 1. Platform: x86-android-tablets: other: Add swnode for Xiaomi pad2
>    indicator LED was included in Hans' branch.
> 2. Included the tags from the previous version in the commit message.
> 3. Fixed the comma issue for the structure initialiser.
> 
> Changes in v6:
> 1. The I2C ID table was moved to a separate patch.
> 2. The LED shows orange when charging.
> 3. The trigger name was renamed to charging-orange-full-green.
> 4. The default trigger of Xiaomi Pad2 is
>    "bq27520-0-charging-orange-full-green".
> 
> Changes in v5:
> 1. Fix swnode LED color settings.
> 2. Improve the driver based on the comments.
> 3. Introduce a LED new API- led_mc_trigger_event() to make the LED
>    color can be changed according to the trigger.
> 4. Introduced a new trigger "charging-red-full-green". The LED will be
>    red when charging and the LED will be green when the battery is full.
> 5. Set the default trigger to "bq27520-0-charging-red-full-green" for
>    Xiaomi Pad2.
> 
> Changes in v4:
> 1. Fix double casting.
> 2. Since force casting a pointer value to int will trigger a compiler
>    warning, the type of num_leds was changed to unsigned long.
> 
> Changes in v3:
> 1. Drop the patch "leds-ktd202x: Skip regulator settings for Xiaomi
>    pad2"
> 
> Changes in v2:
> 1. Typo and style fixes.
> 2. The patch 0003 skips all the regulator setup for Xiaomi pad2 since
>    KTD2026 on Xiaomi pad2 is already powered by BP25890RTWR. So, the
>    sleep can be removed when removing the module.
> 
> Regards,
> 
> Hans
> 
> 
> Hans de Goede (3):
>   leds: rgb: leds-ktd202x: Initialize mutex earlier
>   leds: core: Add led_mc_set_brightness() function
>   leds: trigger: Add led_mc_trigger_event() function
> 
> Kate Hsuan (4):
>   leds: rgb: leds-ktd202x: Get device properties through fwnode to
>     support ACPI
>   leds: rgb: leds-ktd202x: I2C ID tables for KTD2026 and 2027
>   power: supply: power-supply-leds: Add charging_orange_full_green
>     trigger for RGB LED
>   platform: x86-android-tablets: Xiaomi pad2 RGB LED fwnode updates
> 
>  drivers/leds/led-class-multicolor.c           |  1 +
>  drivers/leds/led-core.c                       | 31 +++++++
>  drivers/leds/led-triggers.c                   | 20 +++++
>  drivers/leds/rgb/Kconfig                      |  1 -
>  drivers/leds/rgb/leds-ktd202x.c               | 80 +++++++++++--------
>  .../platform/x86/x86-android-tablets/other.c  |  6 +-
>  drivers/power/supply/power_supply_leds.c      | 23 ++++++
>  include/linux/leds.h                          | 26 ++++++
>  include/linux/power_supply.h                  |  2 +
>  9 files changed, 152 insertions(+), 38 deletions(-)

Set is ready to go, but does not apply.

Please rebase and resubmit, thanks.

-- 
Lee Jones [李琼斯]