public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: intel_pstate_get_hwp_cap on wrong CPU
Date: Fri, 31 May 2024 16:01:40 +0200	[thread overview]
Message-ID: <20240531140140.pfKOWdB-@linutronix.de> (raw)
In-Reply-To: <3eaf90b63edccb3317968101040510c91b5b2f4e.camel@linux.intel.com>

On 2024-05-31 04:56:04 [-0700], srinivas pandruvada wrote:
> > Would you mind letting
> >   /sys/devices/system/cpu/intel_pstate/num_pstates
> > 
> > reporting something sane? Not 4294967285 but 0 for instance? Would
> > that
> > make sense?
> > 
> It should be some good value, usually less than 50. Do you see this
> high number without even triggering condition, which caused warning?

Nope, without the error I see 22. I think this went "-EIO + -EIO -1"
which ended up as what I reported by chance. Never mind then.

> In your system, firmware changed performance notifying via ACPI. That
> method is deprecated for a while. You are using Haswell, which has this
> support. But deprecated from Skylake.

Okay. Anything I should change?

> > Did Sebastian _Reichel_ report it, too?
> My mistake. I picked up wrong Sebastian. Sorry.

Ah okay. Then
Tested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

because it does not do read the MSR in the code path I reported.

> Thanks,
> Srinivas
Sebastian

  reply	other threads:[~2024-05-31 14:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-29 15:57 intel_pstate_get_hwp_cap on wrong CPU Sebastian Andrzej Siewior
2024-05-29 23:08 ` srinivas pandruvada
2024-05-31 11:02   ` Sebastian Andrzej Siewior
2024-05-31 11:56     ` srinivas pandruvada
2024-05-31 14:01       ` Sebastian Andrzej Siewior [this message]
2024-05-31 22:27         ` srinivas pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240531140140.pfKOWdB-@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=lenb@kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox