Re: [PATCH v4] fs: Improve eventpoll logging to stop indicting timerfd

kernel test robot
2024-06-04T22:13:24Z

Hi Isaac,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on rafael-pm/bleeding-edge linus/master v6.10-rc2 next-20240604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Isaac-J-Manjarres/fs-Improve-eventpoll-logging-to-stop-indicting-timerfd/20240605-013918
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20240604173606.998721-1-isaacmanjarres%40google.com
patch subject: [PATCH v4] fs: Improve eventpoll logging to stop indicting timerfd
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20240605/202406050504.UvdlPAQ0-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240605/202406050504.UvdlPAQ0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406050504.UvdlPAQ0-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/base/power/wakeup.c: In function 'wakeup_source_register':
>> drivers/base/power/wakeup.c:223:9: warning: function 'wakeup_source_register' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
223 | vsnprintf(name, sizeof(name), fmt, args);
| ^~~~~~~~~

vim +223 drivers/base/power/wakeup.c

208
209 /**
210 * wakeup_source_register - Create wakeup source and add it to the list.
211 * @dev: Device this wakeup source is associated with (or NULL if virtual).
212 * @fmt: format string for the wakeup source name
213 */
214 struct wakeup_source *wakeup_source_register(struct device *dev,
215 const char *fmt, ...)
216 {
217 struct wakeup_source *ws;
218 int ret;
219 char name[128];
220 va_list args;
221
222 va_start(args, fmt);
> 223 vsnprintf(name, sizeof(name), fmt, args);
224 va_end(args);
225
226 ws = wakeup_source_create(name);
227 if (ws) {
228 if (!dev || device_is_registered(dev)) {
229 ret = wakeup_source_sysfs_add(dev, ws);
230 if (ret) {
231 wakeup_source_free(ws);
232 return NULL;
233 }
234 }
235 wakeup_source_add(ws);
236 }
237 return ws;
238 }
239 EXPORT_SYMBOL_GPL(wakeup_source_register);
240

--
0-DAY CI Kernel Test Service