From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linus.walleij@linaro.org, sre@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] power: supply: ab8500: Fix error handling when calling iio_read_channel_processed()
Date: Sun, 23 Jun 2024 18:16:54 +0100 [thread overview]
Message-ID: <20240623181654.3fe94bbf@jic23-huawei> (raw)
In-Reply-To: <f9f65642331c9e40aaebb888589db043db80b7eb.1719037737.git.christophe.jaillet@wanadoo.fr>
On Sat, 22 Jun 2024 09:04:24 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> The ab8500_charger_get_[ac|vbus]_[current|voltage]() functions should
> return an error code on error.
>
> Up to now, an un-initialized value is returned.
> This makes the error handling of the callers un-reliable.
>
> Return the error code instead, to fix the issue.
>
> Fixes: 97ab78bac5d0 ("power: supply: ab8500_charger: Convert to IIO ADC")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Looks right to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2024-06-23 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 7:04 [PATCH 0/3] power: supply: ab8500: Improve code related to iio_read_channel_processed() and fix a bug Christophe JAILLET
2024-06-22 7:04 ` [PATCH 1/3] power: supply: ab8500: Fix error handling when calling iio_read_channel_processed() Christophe JAILLET
2024-06-23 17:16 ` Jonathan Cameron [this message]
2024-06-26 10:38 ` Linus Walleij
2024-06-22 7:04 ` [PATCH 2/3] power: supply: ab8500: Use iio_read_channel_processed_scale() Christophe JAILLET
2024-06-23 17:18 ` Jonathan Cameron
2024-06-26 10:39 ` Linus Walleij
2024-06-22 7:04 ` [PATCH 3/3] power: supply: ab8500: Clean some error messages Christophe JAILLET
2024-06-23 17:19 ` Jonathan Cameron
2024-06-26 10:39 ` Linus Walleij
2024-06-26 13:06 ` [PATCH 0/3] power: supply: ab8500: Improve code related to iio_read_channel_processed() and fix a bug Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240623181654.3fe94bbf@jic23-huawei \
--to=jic23@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox