Re: [PATCH v4 00/11] Add per-core RAPL energy counter support for AMD CPUs

Ian Rogers
2024-07-17T15:36:25Z

On Wed, Jul 17, 2024 at 1:05 AM Dhananjay Ugwekar
<Dhananjay.Ugwekar@amd.com> wrote:
...
> Sounds great!, I'll be happy to refactor the RAPL code to use the event.cpumask
> feature to add the per-core energy counter. Also, please let me know if you need
> any help from me on the perf tool side as well.

I hope to send out some patches soon. One thought I have is that
"event.cpumask" is probably less intention revealing the "event.cpus"
as a name, so I'm going to code assuming the suffix is ".cpus" but
obviously we can change it to ".cpumask". To me the "mask" makes it
sound like we "and" the values with something, hence wanting to avoid
the confusion. There's much confusion in the area already, such as the
term "cpu map" that does not implement some kind of map.

Thanks,
Ian