linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Lippers-Hollmann <s.l-h@gmx.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Eric Biggers <ebiggers@kernel.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Zhang Rui <rui.zhang@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH v3] thermal: core: Call monitor_thermal_zone() if zone temperature is invalid
Date: Tue, 16 Jul 2024 01:48:30 +0200	[thread overview]
Message-ID: <20240716014830.243bb0cf@mir> (raw)
In-Reply-To: <CAJZ5v0gPiwkNczZhCf_rkxVoUX33tS9c6irMf_7=Rg48Nw9C4w@mail.gmail.com>

Hi

On 2024-07-15, Rafael J. Wysocki wrote:
> On Mon, Jul 15, 2024 at 2:54 PM Stefan Lippers-Hollmann <s.l-h@gmx.de> wrote:
> > On 2024-07-15, Rafael J. Wysocki wrote:
> > > On Mon, Jul 15, 2024 at 11:09 AM Daniel Lezcano
> > > <daniel.lezcano@linaro.org> wrote:
> > > > On 15/07/2024 06:45, Eric Biggers wrote:
> > > > > On Thu, Jul 04, 2024 at 01:46:26PM +0200, Rafael J. Wysocki wrote:
> > > > >> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
[...]
> > Silencing the warnings is already a big improvement - and that patch
> > works to this extent for me with an ax200, thanks.
>
> So attached is a patch that should avoid enabling the thermal zone
> when it is not ready for use in the first place, so it should address
> both the message and the useless polling.
>
> I would appreciate giving it a go (please note that it hasn't received
> much testing so far, though).

Sadly this patch doesn't seem to help:

$ dmesg  | grep -e iwlwifi -e thermal
[    0.113700] thermal_sys: Registered thermal governor 'fair_share'
[    0.113700] thermal_sys: Registered thermal governor 'bang_bang'
[    0.113700] thermal_sys: Registered thermal governor 'step_wise'
[    0.113700] thermal_sys: Registered thermal governor 'user_space'
[    0.113700] thermal_sys: Registered thermal governor 'power_allocator'
[    3.885485] iwlwifi 0000:04:00.0: enabling device (0140 -> 0142)
[    3.888462] iwlwifi 0000:04:00.0: Detected crf-id 0x3617, cnv-id 0x100530 wfpm id 0x80000000
[    3.888471] iwlwifi 0000:04:00.0: PCI dev 2723/0084, rev=0x340, rfid=0x10a100
[    3.892720] iwlwifi 0000:04:00.0: TLV_FW_FSEQ_VERSION: FSEQ Version: 89.3.35.37
[    3.994292] iwlwifi 0000:04:00.0: loaded firmware version 77.a20fb07d.0 cc-a0-77.ucode op_mode iwlmvm
[    4.383879] iwlwifi 0000:04:00.0: Detected Intel(R) Wi-Fi 6 AX200 160MHz, REV=0x340
[    4.513229] iwlwifi 0000:04:00.0: Detected RF HR B3, rfid=0x10a100
[    4.578828] iwlwifi 0000:04:00.0: base HW address: 94:e6:f7:XX:XX:XX
[    4.592597] thermal thermal_zone2: failed to read out thermal zone (-61)
[    4.604651] iwlwifi 0000:04:00.0 wlp4s0: renamed from wlan0
[    4.849442] thermal thermal_zone2: failed to read out thermal zone (-61)
[    5.105488] thermal thermal_zone2: failed to read out thermal zone (-61)
[    5.361470] thermal thermal_zone2: failed to read out thermal zone (-61)
[    5.618458] thermal thermal_zone2: failed to read out thermal zone (-61)
[    5.873428] thermal thermal_zone2: failed to read out thermal zone (-61)
[    6.129429] thermal thermal_zone2: failed to read out thermal zone (-61)
[    6.385446] thermal thermal_zone2: failed to read out thermal zone (-61)
[    6.641695] thermal thermal_zone2: failed to read out thermal zone (-61)

Regards
	Stefan Lippers-Hollmann

P.S.: I've now also noticed the same issue on a raptor-lake system with AX201.

  parent reply	other threads:[~2024-07-15 23:48 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04 11:46 [PATCH v3] thermal: core: Call monitor_thermal_zone() if zone temperature is invalid Rafael J. Wysocki
2024-07-04 12:49 ` Daniel Lezcano
2024-07-04 12:52   ` Neil Armstrong
2024-07-04 14:23     ` Rafael J. Wysocki
2024-07-04 14:21   ` Rafael J. Wysocki
2024-07-04 16:53     ` Daniel Lezcano
2024-07-04 16:58       ` Rafael J. Wysocki
2024-07-15  4:45 ` Eric Biggers
2024-07-15  9:06   ` Stefan Lippers-Hollmann
2024-07-15 10:52     ` Rafael J. Wysocki
2024-07-15  9:09   ` Daniel Lezcano
2024-07-15 11:21     ` Rafael J. Wysocki
2024-07-15 12:54       ` Stefan Lippers-Hollmann
2024-07-15 14:48         ` Rafael J. Wysocki
2024-07-15 21:12           ` Eric Biggers
2024-07-15 23:48           ` Stefan Lippers-Hollmann [this message]
2024-07-16 10:05             ` Rafael J. Wysocki
2024-07-16 10:55               ` Stefan Lippers-Hollmann
2024-07-16 11:15                 ` Stefan Lippers-Hollmann
2024-07-16 11:36                   ` Rafael J. Wysocki
2024-07-16 12:10                     ` Daniel Lezcano
2024-07-16 12:18                       ` Rafael J. Wysocki
2024-07-16 12:30                     ` Rafael J. Wysocki
2024-07-16 13:20                       ` Stefan Lippers-Hollmann
2024-07-16 14:04                         ` Rafael J. Wysocki
2024-07-16 16:37                           ` Oleksandr Natalenko
2024-07-16 17:03                             ` Rafael J. Wysocki
2024-07-16 23:30                           ` Stefan Lippers-Hollmann
2024-07-16 11:19                 ` Rafael J. Wysocki
2024-07-15 10:49   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240716014830.243bb0cf@mir \
    --to=s.l-h@gmx.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=ebiggers@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).