From: Artur Weber <aweber.kernel@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Henrik Grimler <henrik@grimler.se>,
Wolfgang Wiedmeyer <wolfgit@wiedmeyer.de>,
Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>,
Artur Weber <aweber.kernel@gmail.com>
Subject: [PATCH v3 06/10] power: supply: max77693: Add support for detecting and enabling OTG
Date: Mon, 29 Jul 2024 19:47:40 +0200 [thread overview]
Message-ID: <20240729-max77693-charger-extcon-v3-6-02315a6869d4@gmail.com> (raw)
In-Reply-To: <20240729-max77693-charger-extcon-v3-0-02315a6869d4@gmail.com>
Building upon the newly added extcon detection support, add detection
for USB OTG cables (EXTCON_USB_HOST type), and enable/disable the OTG
bits as needed.
Acked-by: Lee Jones <lee@kernel.org>
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
Changes in v3:
- Dropped CHARGER regulator in favor of enabling charging directly
Changes in v2:
- Added CHGIN OTG current limit value
- Squashed MFD header register changes into this commit
---
drivers/power/supply/max77693_charger.c | 53 ++++++++++++++++++++++++++-------
include/linux/mfd/max77693-private.h | 5 ++++
2 files changed, 48 insertions(+), 10 deletions(-)
diff --git a/drivers/power/supply/max77693_charger.c b/drivers/power/supply/max77693_charger.c
index 2e05467c682e..4ff402941d72 100644
--- a/drivers/power/supply/max77693_charger.c
+++ b/drivers/power/supply/max77693_charger.c
@@ -692,11 +692,30 @@ static int max77693_set_charging(struct max77693_charger *chg, bool enable)
data);
}
+static int max77693_set_otg(struct max77693_charger *chg, bool enable)
+{
+ unsigned int data;
+
+ if (enable)
+ data = CHG_CNFG_00_OTG_MASK | CHG_CNFG_00_BOOST_MASK |
+ CHG_CNFG_00_DIS_MUIC_CTRL_MASK;
+ else
+ data = ~(CHG_CNFG_00_OTG_MASK | CHG_CNFG_00_BOOST_MASK |
+ CHG_CNFG_00_DIS_MUIC_CTRL_MASK);
+
+ return regmap_update_bits(chg->max77693->regmap,
+ MAX77693_CHG_REG_CHG_CNFG_00,
+ CHG_CNFG_00_OTG_MASK | CHG_CNFG_00_BOOST_MASK |
+ CHG_CNFG_00_DIS_MUIC_CTRL_MASK,
+ data);
+}
+
static void max77693_charger_extcon_work(struct work_struct *work)
{
struct max77693_charger *chg = container_of(work, struct max77693_charger,
cable.work);
struct extcon_dev *edev = chg->cable.edev;
+ bool set_charging, set_otg;
int connector, state;
int ret;
@@ -715,25 +734,39 @@ static void max77693_charger_extcon_work(struct work_struct *work)
case EXTCON_CHG_USB_FAST:
case EXTCON_CHG_USB_SLOW:
case EXTCON_CHG_USB_PD:
- ret = max77693_set_charging(chg, true);
- if (ret) {
- dev_err(chg->dev, "failed to enable charging\n");
- break;
- }
+ set_charging = true;
+ set_otg = false;
+
dev_info(chg->dev, "charging. connector type: %d\n",
connector);
break;
+ case EXTCON_USB_HOST:
+ set_charging = false;
+ set_otg = true;
+
+ dev_info(chg->dev, "USB host. connector type: %d\n",
+ connector);
+ break;
default:
- ret = max77693_set_charging(chg, false);
- if (ret) {
- dev_err(chg->dev, "failed to disable charging\n");
- break;
- }
+ set_charging = false;
+ set_otg = false;
+
dev_info(chg->dev, "not charging. connector type: %d\n",
connector);
break;
}
+ ret = max77693_set_charging(chg, set_charging);
+ if (ret) {
+ dev_err(chg->dev, "failed to set charging (%d)\n", ret);
+ goto out;
+ }
+
+ ret = max77693_set_otg(chg, set_otg);
+ if (ret)
+ dev_err(chg->dev, "failed to set OTG (%d)\n", ret);
+
+out:
power_supply_changed(chg->charger);
}
diff --git a/include/linux/mfd/max77693-private.h b/include/linux/mfd/max77693-private.h
index 0819cf0a4f5f..1fd93bfbf3dc 100644
--- a/include/linux/mfd/max77693-private.h
+++ b/include/linux/mfd/max77693-private.h
@@ -209,7 +209,10 @@ enum max77693_charger_battery_state {
/* MAX77693 CHG_CNFG_00 register */
#define CHG_CNFG_00_CHG_MASK 0x1
+#define CHG_CNFG_00_OTG_MASK 0x2
#define CHG_CNFG_00_BUCK_MASK 0x4
+#define CHG_CNFG_00_BOOST_MASK 0x8
+#define CHG_CNFG_00_DIS_MUIC_CTRL_MASK 0x20
/* MAX77693_CHG_REG_CHG_CNFG_01 register */
#define CHG_CNFG_01_FCHGTIME_SHIFT 0
@@ -222,6 +225,8 @@ enum max77693_charger_battery_state {
/* MAX77693_CHG_REG_CHG_CNFG_02 register */
#define CHG_CNFG_02_CC_SHIFT 0
#define CHG_CNFG_02_CC_MASK 0x3F
+#define CHG_CNFG_02_OTG_ILIM_SHIFT 7
+#define CHG_CNFG_02_OTG_ILIM_MASK 0x80
/* MAX77693_CHG_REG_CHG_CNFG_03 register */
#define CHG_CNFG_03_TOITH_SHIFT 0
--
2.45.2
next prev parent reply other threads:[~2024-07-29 17:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 17:47 [PATCH v3 00/10] power: supply: max77693: Toggle charging/OTG based on extcon status Artur Weber
2024-07-29 17:47 ` [PATCH v3 01/10] dt-bindings: power: supply: max77693: Add monitored-battery property Artur Weber
2024-07-29 17:47 ` [PATCH v3 02/10] dt-bindings: power: supply: max77693: Add maxim,usb-connector property Artur Weber
2024-07-29 17:47 ` [PATCH v3 03/10] power: supply: max77693: Expose input current limit and CC current properties Artur Weber
2024-07-29 17:47 ` [PATCH v3 04/10] power: supply: max77693: Set charge current limits during init Artur Weber
2024-07-29 17:47 ` [PATCH v3 05/10] power: supply: max77693: Add USB extcon detection for enabling charging Artur Weber
2024-07-29 17:47 ` Artur Weber [this message]
2024-07-29 17:47 ` [PATCH v3 07/10] power: supply: max77693: Set up charge/input current according to cable type Artur Weber
2024-07-29 17:47 ` [PATCH v3 08/10] ARM: dts: samsung: exynos4212-tab3: Add battery node with charge current value Artur Weber
2024-09-28 12:54 ` Krzysztof Kozlowski
2024-07-29 17:47 ` [PATCH v3 09/10] ARM: dts: samsung: exynos4212-tab3: Add USB connector node Artur Weber
2024-07-29 17:47 ` [PATCH v3 10/10] ARM: dts: exynos4212-tab3: Drop CHARGER regulator Artur Weber
2024-08-01 6:22 ` [PATCH v3 00/10] power: supply: max77693: Toggle charging/OTG based on extcon status Henrik Grimler
2024-08-04 10:59 ` Henrik Grimler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729-max77693-charger-extcon-v3-6-02315a6869d4@gmail.com \
--to=aweber.kernel@gmail.com \
--cc=GNUtoo@cyberdimension.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=wolfgit@wiedmeyer.de \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox