From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A95BB176AA3 for ; Thu, 15 Aug 2024 07:33:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723707201; cv=none; b=lBcVLPPQ4y4Bcq/UW8t7Jf2WglXJhJOsiabWTuE/IbODOKHBxfzv8aeaYgrveuB1nUK+zq0yOf3v9OBDtLP2yyGrtwFcB4FzzEdmQI6p676Vd/fc0qvJVHYZnu4QfNdgJRwqbOfwvN2TR6j4Ec09pm98oMYsXdX4bQRntEYL0ZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723707201; c=relaxed/simple; bh=LCZqNlothIJ7iUi0FaViXUQV8VMf+8pHOfULUFoQPlg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oRMy8p32ICpaqaacj2vLSw3UjPa45ZjD0Ee7j48mqhg7CGjDOOLpqf9xr9ec51vVJuxRBpG0RFn5Rom+tpxxcm8iCHI8Jbuq3lM843jEw7zHOg1UqAVdjLkeEgU6w0mlOo1ZxqaYQvs6kA44PtLOPg8u24jk0NlLDDw+2Iv1FmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=H3Ygra5j; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="H3Ygra5j" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-70d18d4b94cso480258b3a.2 for ; Thu, 15 Aug 2024 00:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723707199; x=1724311999; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mSVgOh4W3trTwpBrRTkuN1lvc7J54SJDhoOOLbBw+iU=; b=H3Ygra5j6izjFuKBbcoHy/HiVK8e12hsJniFGdD3G3ndnf8qF5w5XCQErswkq0woi0 Waj2qJpPLUP8s/gX/YOCaSA9PGFH/46AQsmhUYEzFFl13H+tXjpVYp/RIso9Cj6c/QZB smfKh6oOd36hGUc+fPq3A3cFlM0qfU7vgpeaU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723707199; x=1724311999; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mSVgOh4W3trTwpBrRTkuN1lvc7J54SJDhoOOLbBw+iU=; b=jNBgQ0X3+rxkEk16dQH3BeMfwjREnM0OJqv2Y1pyb2rAFKk/wvELULhd4PkcbRt8KT TJmjOayeahXK+QVAkf88cg13CTp+bgGNJ/ws5SErR/6F74Fumj94gOQ7N83htBZH0cqa s2tSP3Jh8stuD2TaL/fv9pbgRtB5zfiE7O8MZoPGrh6ENy4u9J/9s9nn2W450AonHZZm yZiIlEslwnIYp4N4/xi48QhyDh/dU70AQNKjCIx8ACAeo4pGJpM220aTryOgEpfZSu/o tTq6vbkeAFpNaYUTmaq79tXJ6F4vhvbfQoCXhvOG7Hh35Znxw97TubIV55SZs1Zn1FL1 IcDw== X-Forwarded-Encrypted: i=1; AJvYcCVlvkDk/uJowBLRocy5tP2j/7VyLPfhY5UhPpdG8715f6Rhcrq/FKSTc08Z507oiqSwStSCJbtx6t6HNOf1Np1PrSSLtDmmeQw= X-Gm-Message-State: AOJu0YzyIuPb0AhMUyyZSjXfuHem2rMdKggYElJFnfrfr8cYiPhcW8S8 6SEBWWkQx8rdWpA4b8J62FLvRH8xyQqJ9TZR7begtNlQcAsH/cn9LfIZMIsJGw== X-Google-Smtp-Source: AGHT+IE+v6e+Df7tQx88UbXmfy+wlQroZUtqBIcjWsCC3V2G6r5uCEDNzWqCeTXlE1H5mKvT4LnM9w== X-Received: by 2002:a05:6a00:1394:b0:705:a13b:e740 with SMTP id d2e1a72fcca58-712673abaf0mr5999238b3a.19.1723707199046; Thu, 15 Aug 2024 00:33:19 -0700 (PDT) Received: from google.com ([2401:fa00:1:10:745d:58f7:b3cd:901f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7127aef544csm563951b3a.121.2024.08.15.00.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2024 00:33:18 -0700 (PDT) Date: Thu, 15 Aug 2024 15:33:14 +0800 From: Chen-Yu Tsai To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Amit Kucheria , Thara Gopinath , Thierry Reding , Jonathan Hunter , Vasily Khoruzhick , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 7/7] thermal: sun8i: Use scoped device node handling to simplify error paths Message-ID: <20240815073314.GG350960@google.com> References: <20240814-b4-cleanup-h-of-node-put-thermal-v1-0-7a1381e1627e@linaro.org> <20240814-b4-cleanup-h-of-node-put-thermal-v1-7-7a1381e1627e@linaro.org> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240814-b4-cleanup-h-of-node-put-thermal-v1-7-7a1381e1627e@linaro.org> On Wed, Aug 14, 2024 at 10:17:53PM +0200, Krzysztof Kozlowski wrote: > Obtain the device node reference with scoped/cleanup.h to reduce error > handling and make the code a bit simpler. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Chen-Yu Tsai > --- > drivers/thermal/sun8i_thermal.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c > index 3203d8bd13a8..22674790629a 100644 > --- a/drivers/thermal/sun8i_thermal.c > +++ b/drivers/thermal/sun8i_thermal.c > @@ -9,6 +9,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -348,19 +349,18 @@ static void sun8i_ths_reset_control_assert(void *data) > > static struct regmap *sun8i_ths_get_sram_regmap(struct device_node *node) > { > - struct device_node *sram_node; > struct platform_device *sram_pdev; > struct regmap *regmap = NULL; > > - sram_node = of_parse_phandle(node, "allwinner,sram", 0); > + struct device_node *sram_node __free(device_node) = > + of_parse_phandle(node, "allwinner,sram", 0); > if (!sram_node) > return ERR_PTR(-ENODEV); > > sram_pdev = of_find_device_by_node(sram_node); > if (!sram_pdev) { > /* platform device might not be probed yet */ > - regmap = ERR_PTR(-EPROBE_DEFER); > - goto out_put_node; > + return ERR_PTR(-EPROBE_DEFER); > } > > /* If no regmap is found then the other device driver is at fault */ > @@ -369,8 +369,7 @@ static struct regmap *sun8i_ths_get_sram_regmap(struct device_node *node) > regmap = ERR_PTR(-EINVAL); > > platform_device_put(sram_pdev); > -out_put_node: > - of_node_put(sram_node); > + > return regmap; > } > > > -- > 2.43.0 >