From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D85F17BB28; Mon, 19 Aug 2024 16:02:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724083347; cv=none; b=Z+fQvSsBKK/sUoNj+2KG8C+AcuKEN5uzjqCHeA2/xIIdzGfnIKb0/PaALV/+LdprmJwUfexiX9Cx1mfD5yykgJ/ZcIG6oSbT7dEKecZgKiwvYt+KaMWQk8We7NZSAxRLHRISo6hzJMenAjA95bGNg90mL4psbIe9o5vaFHiT02U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724083347; c=relaxed/simple; bh=ddWC9mKzp2YiVucUrnXKI0CCSWBopEDMWS4/H1h5CVM=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GQ6hRLUVSsLdF+4/Zv1FuUTn7I/vfNG5jmfts7F3ytRmX7wCfI6bNfgKAU1Xc9nbjPonN7Jar5dtgaGPON6EgAqn6lRdqcGREoRxFNzwiCcO1AZx7hr3eFjHHEtf2OFD3iLew5m1ZD+y8XMl5lt9qBzjUZ/m2eXA2Pm5goItqfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WncjN0N3fz67HSr; Mon, 19 Aug 2024 23:59:20 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 38E47140594; Tue, 20 Aug 2024 00:02:23 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 19 Aug 2024 17:02:22 +0100 Date: Mon, 19 Aug 2024 17:02:21 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski CC: Krzysztof Kozlowski , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Lukasz Luba , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Thierry Reding , Jonathan Hunter , Santosh Shilimkar , , , , , , Subject: Re: [PATCH v2 06/13] memory: stm32-fmc2-ebi: simplify with dev_err_probe() Message-ID: <20240819170221.00002f91@Huawei.com> In-Reply-To: <20240816-cleanup-h-of-node-put-memory-v2-6-9eed0ee16b78@linaro.org> References: <20240816-cleanup-h-of-node-put-memory-v2-0-9eed0ee16b78@linaro.org> <20240816-cleanup-h-of-node-put-memory-v2-6-9eed0ee16b78@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) On Fri, 16 Aug 2024 12:54:30 +0200 Krzysztof Kozlowski wrote: > dev_err_probe() combines 'return' and error code printing, thus code is > a bit simpler, even if it cannot actually defer. > > Suggested-by: Jonathan Cameron > Signed-off-by: Krzysztof Kozlowski LGTM Reviewed-by: Jonathan Cameron