From: Greg KH <gregkh@linuxfoundation.org>
To: Yibin Ding <Yibin.Ding@unisoc.com>
Cc: djakov@kernel.org, rafael@kernel.org, yibin.ding01@gmail.com,
niuzhiguo84@gmail.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Hao_hao.Wang@unisoc.com,
Ke.Wang@unisoc.com
Subject: Re: [PATCH 0/2] Added debugfs node initialization and null pointer detection.
Date: Fri, 30 Aug 2024 12:32:27 +0200 [thread overview]
Message-ID: <2024083057-factor-bonfire-73de@gregkh> (raw)
In-Reply-To: <20240830102153.408675-1-Yibin.Ding@unisoc.com>
On Fri, Aug 30, 2024 at 06:21:53PM +0800, Yibin Ding wrote:
> From: Yibin Ding <Yibin.ding@unisoc.com>
>
> The two debugfs nodes (/sys/kernel/debug/interconnect/test_client/dst_node,
> src_node) do not initialize the character pointers before creation. For
> such uninitialized nodes, direct access will cause a crash due to accessing
> a null pointer.
> For example, directly execute the following command after booting:
> cat /sys/kernel/debug/interconnect/test_client/dst_node.
>
> Therefore, for the problem nodes, it is necessary to add initialization
> operations and null pointer detection when accessing.
>
> Yibin Ding (2):
> interconnect: Add character pointer initialization
> debugfs: Fix crash problem caused by accessing uninitialized nodes
>
> drivers/interconnect/debugfs-client.c | 10 ++++++++--
> fs/debugfs/file.c | 4 ++++
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> --
> 2.25.1
>
This series is not properly threaded for some reason. Can you resend
using a tool (like git send-email or something else) that preserves it
so that our tools can correctly pick them up?
thanks,
greg k-h
prev parent reply other threads:[~2024-08-30 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 10:21 [PATCH 0/2] Added debugfs node initialization and null pointer detection Yibin Ding
2024-08-30 10:32 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024083057-factor-bonfire-73de@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Hao_hao.Wang@unisoc.com \
--cc=Ke.Wang@unisoc.com \
--cc=Yibin.Ding@unisoc.com \
--cc=djakov@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=niuzhiguo84@gmail.com \
--cc=rafael@kernel.org \
--cc=yibin.ding01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox