From: Min-Hua Chen <minhuadotchen@gmail.com>
To: jwyatt@redhat.com
Cc: jkacur@redhat.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, minhuadotchen@gmail.com,
shuah@kernel.org, skhan@linuxfoundation.org, trenn@suse.com
Subject: Re: [RFC PATCH for-next] pm: cpupower: rename raw_pylibcpupower.i
Date: Fri, 13 Sep 2024 06:49:15 +0800 [thread overview]
Message-ID: <20240912224916.79367-1-minhuadotchen@gmail.com> (raw)
In-Reply-To: <ZuMmqAmr62ErjqHc@rhfedora>
Hi,
>On Thu, Sep 12, 2024 at 10:31:19AM -0600, Shuah Khan wrote:
>> On 9/12/24 06:50, Min-Hua Chen wrote:
>> > This RFC patch is actually bug report. All *.i file will be
>> > removed by 'make mrproper', including raw_pylibcpupower.i, added
>> > by commit: 338f490e07bc ("pm:cpupower: Add SWIG bindings files for libcpupower")
>> >
>> > We can reproduce the error by performing the following command:
>> > cd linux-next
>> > make mrproper
>> > cd tools/power/cpupower/bindings/python
>> > make
>> >
>> > We will get an error message:
>> > make: *** No rule to make target 'raw_pylibcpupower.i', needed by 'raw_pylibcpupower_wrap.c'. Stop.
>> >
>> > Renaming the raw_pylibcpupower.i is just a workaround to fix the
>> > issue above.
>>
>> I need a non-rfc patch for this. Please send a proper patch
>> I can pull in once John has a chance to review this.
>
>I have reviewed and tested and this. I am good with it being a stopgap.
>
>Please send the non-rfc patch.
>
>Thank you for reporting and sending a patch for this Min-Hua.
>
>Reviewed-by: John B. Wyatt IV <jwyatt@redhat.com>
>Reviewed-by: John B. Wyatt IV <sageofredondo@gmail.com>
>Tested-by: John B. Wyatt IV <jwyatt@redhat.com>
>Tested-by: John B. Wyatt IV <sageofredondo@gmail.com>
Thank you for reviewing this patch, I will submit a non-rfc patch later.
cheers,
Min-Hua
prev parent reply other threads:[~2024-09-12 22:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 12:50 [RFC PATCH for-next] pm: cpupower: rename raw_pylibcpupower.i Min-Hua Chen
2024-09-12 16:31 ` Shuah Khan
2024-09-12 17:36 ` John B. Wyatt IV
2024-09-12 20:03 ` Shuah Khan
2024-09-12 22:55 ` Min-Hua Chen
2024-09-13 16:35 ` John B. Wyatt IV
2024-09-13 16:45 ` Shuah Khan
2024-09-12 22:49 ` Min-Hua Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912224916.79367-1-minhuadotchen@gmail.com \
--to=minhuadotchen@gmail.com \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox