From: Yibin Ding <Yibin.Ding@unisoc.com>
To: <djakov@kernel.org>, <gregkh@linuxfoundation.org>, <rafael@kernel.org>
Cc: <yibin.ding01@gmail.com>, <niuzhiguo84@gmail.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<Hao_hao.Wang@unisoc.com>, <Ke.Wang@unisoc.com>
Subject: [PATCH V2 1/2] interconnect: Add character pointer initialization
Date: Sat, 14 Sep 2024 18:24:35 +0800 [thread overview]
Message-ID: <20240914102435.3879355-1-Yibin.Ding@unisoc.com> (raw)
From: Yibin Ding <Yibin.ding@unisoc.com>
When accessing a node whose data type is a character pointer and has not
been initialized, a crash will occur due to accessing a null pointer. So
it is necessary to add the operation of initializing the character pointer.
Since the debugfs_write_file_str() function performs a kfree() operation
on the node data, memory is allocated to the node pointer during
initialization will be released when data is written to the node.
Signed-off-by: Yibin Ding <Yibin.ding@unisoc.com>
---
drivers/interconnect/debugfs-client.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/interconnect/debugfs-client.c b/drivers/interconnect/debugfs-client.c
index bc3fd8a7b9eb..a1c99b9d3b9a 100644
--- a/drivers/interconnect/debugfs-client.c
+++ b/drivers/interconnect/debugfs-client.c
@@ -147,8 +147,13 @@ int icc_debugfs_client_init(struct dentry *icc_dir)
client_dir = debugfs_create_dir("test_client", icc_dir);
- debugfs_create_str("src_node", 0600, client_dir, &src_node);
- debugfs_create_str("dst_node", 0600, client_dir, &dst_node);
+ src_node = kzalloc(sizeof(src_node), GFP_KERNEL);
+ dst_node = kzalloc(sizeof(dst_node), GFP_KERNEL);
+
+ if (src_node)
+ debugfs_create_str("src_node", 0600, client_dir, &src_node);
+ if (dst_node)
+ debugfs_create_str("dst_node", 0600, client_dir, &dst_node);
debugfs_create_file("get", 0200, client_dir, NULL, &icc_get_fops);
debugfs_create_u32("avg_bw", 0600, client_dir, &avg_bw);
debugfs_create_u32("peak_bw", 0600, client_dir, &peak_bw);
--
2.25.1
next reply other threads:[~2024-09-14 10:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 10:24 Yibin Ding [this message]
2024-09-14 13:56 ` [PATCH V2 1/2] interconnect: Add character pointer initialization Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240914102435.3879355-1-Yibin.Ding@unisoc.com \
--to=yibin.ding@unisoc.com \
--cc=Hao_hao.Wang@unisoc.com \
--cc=Ke.Wang@unisoc.com \
--cc=djakov@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=niuzhiguo84@gmail.com \
--cc=rafael@kernel.org \
--cc=yibin.ding01@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox