Re: [PATCH 2/3] dt-bindings: mfd: twl: add charger node also for TWL603x

Andreas Kemnade
2024-09-18T11:35:54Z

Am Wed, 18 Sep 2024 12:47:22 +0200
schrieb Krzysztof Kozlowski <krzk@kernel.org>:

> On 18/09/2024 10:41, Andreas Kemnade wrote:
> > Also the TWL603X devices have a charger, so allow to specify it
> > here.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> > .../devicetree/bindings/mfd/ti,twl.yaml | 18
> > ++++++++++++++++++ 1 file changed, 18 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> > b/Documentation/devicetree/bindings/mfd/ti,twl.yaml index
> > e94b0fd7af0f8..4064a228cb0fc 100644 ---
> > a/Documentation/devicetree/bindings/mfd/ti,twl.yaml +++
> > b/Documentation/devicetree/bindings/mfd/ti,twl.yaml @@ -105,6
> > +105,11 @@ allOf: regulator-initial-mode: false
> >
> > properties:
> > + bci:
>
> charger
>
> > + type: object
>
> additionalProperties: true
>
> Each node must end with additionalProperties or unevaluated. I think
> you never tested it, because dtschema reports this.
>
I did run it, no complaints:

andi@aktux:~/kernel$ touch Documentation/devicetree/bindings/mfd/ti,twl.yaml
andi@aktux:~/kernel$ touch Documentation/devicetree/bindings/power/supply/ti,twl6030-charger.yaml
andi@aktux:~/kernel$ make ARCH=arm dt_binding_check DT_SCHEMA_FILES=twl
SCHEMA Documentation/devicetree/bindings/processed-schema.json
/home/andi/kernel/Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing type definition
CHKDT Documentation/devicetree/bindings
LINT Documentation/devicetree/bindings
DTC [C] Documentation/devicetree/bindings/power/supply/twl4030-charger.example.dtb
DTEX Documentation/devicetree/bindings/power/supply/ti,twl6030-charger.example.dts
DTC [C] Documentation/devicetree/bindings/power/supply/ti,twl6030-charger.example.dtb
DTC [C] Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.example.dtb
DTC [C] Documentation/devicetree/bindings/iio/adc/ti,twl4030-madc.example.dtb
DTEX Documentation/devicetree/bindings/mfd/ti,twl.example.dts
DTC [C] Documentation/devicetree/bindings/mfd/ti,twl.example.dtb
andi@aktux:~/kernel$

Regards,
Andreas