Re: [PATCH 2/3] dt-bindings: mfd: twl: add charger node also for TWL603x

Krzysztof Kozlowski
2024-09-18T10:47:28Z

On 18/09/2024 10:41, Andreas Kemnade wrote:
> Also the TWL603X devices have a charger, so allow to specify it here.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> .../devicetree/bindings/mfd/ti,twl.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> index e94b0fd7af0f8..4064a228cb0fc 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> @@ -105,6 +105,11 @@ allOf:
> regulator-initial-mode: false
>
> properties:
> + bci:

charger

> + type: object

additionalProperties: true

Each node must end with additionalProperties or unevaluated. I think you
never tested it, because dtschema reports this.

> + properties:
> + compatible:
> + const: ti,twl6030-charger
> gpadc:
> type: object
> properties:
> @@ -136,6 +141,13 @@ allOf:
> regulator-initial-mode: false
>
> properties:
> + bci:
> + type: object
> + properties:
> + compatible:
> + items:
> + - const: ti,twl6032-charger
> + - const: ti,twl6030-charger
> gpadc:
> type: object
> properties:
> @@ -222,6 +234,12 @@ examples:
> interrupt-controller;
> #interrupt-cells = <1>;
>
> + bci {
> + compatible = "ti,twl6030-charger";
> + interrupts = <2>, <5>;
> + monitored-battery = <&bat>;

One complete example in parent node, so you can drop example from patch #1.

> + };
> +
> gpadc {
> compatible = "ti,twl6030-gpadc";
> interrupts = <6>;

Best regards,
Krzysztof