Re: [PATCH 3/3] power: supply: initial support for TWL6030/32

Andreas Kemnade
2024-09-18T12:43:32Z

Am Wed, 18 Sep 2024 12:43:01 +0200
schrieb Krzysztof Kozlowski <krzk@kernel.org>:

[...]
> Drop {}, see checkpatch.
>
> > + return dev_err_probe(&pdev->dev, ret,
> > + "could not request irq %d\n",
> > + charger->irq_chg);
> > + }
> > +

Apparently checkpatch only moans about {} around single *lines*
not single *statements*, even with --strict.

Coding-style says single statements, so maybe checkpatch should be
fixed?

Same for other appearance of this pattern.

> > + /* turing to charging to configure things */
> > + twl6030_charger_write(CONTROLLER_CTRL1, 0);
> > + twl6030_charger_interrupt(0, charger);
> > +
> > + return 0;
> > +}
> > +
> > +static const struct of_device_id twl_charger_of_match[]
> > __maybe_unused = {
> > + {.compatible = "ti,twl6030-charger", },
> > + {.compatible = "ti,twl6032-charger", },
>
> So they are compatible? Why two entries in such case?
>
There is one device_is_compatible() in the file.

Regrads,
Andreas