Re: [PATCH v2 0/5] acpi/x86: s2idle: move Display off/on calls outside suspend (fixes ROG Ally suspend)

Antheas Kapenekakis
2024-09-23T16:11:57Z

> I don't think it's possible to have it both ways that the ordering is
> wrong AND the timing is wrong.

I think the current firmware manifests 2 issues on the Ally X: Display
On needed to be called once the kernel is ready otherwise it NOOPed
and Display Off needed to be called 1 second before suspend. Then,
there is the issue in my previous email that also exists in Windows.

I tried from 0 - 4000ms for Display off and 0 - 1500ms for Display on.
Display Off, as long as the RGB fades 100-200ms before, made no
difference. Display On likewise made no difference.

I am currently playing a bit with the calls in the Legion Go. Seems
like one of them turns off its controller as well.

I did not know fwupd could do microprocessors, if it is simple that
would be great.

Antheas