Re: [PATCH v2 0/5] acpi/x86: s2idle: move Display off/on calls outside suspend (fixes ROG Ally suspend)

Mario Limonciello
2024-09-23T17:15:34Z

On 9/23/2024 11:54, Antheas Kapenekakis wrote:

>> I hope that more of these handhelds with MCUs that get regular updates
>> make the same investment.
>
> I do not think every manufacturer creates a HID spec for updates. They
> use the same cookiecutter stuff, for which there is no linux
> implementation at all, so kind of the same. Probably after we do 1-3,
> we will have all of them.

Actually there are already about a dozen implementations for HID
protocols in fwupd. I've written a few myself, Richard has written way
more than me, and there are even have vendors contributing to their own
plugins now.

I do think that it's very likely that ASUS uses the same implementation
on a lot of their devices, so yes if we get firmware updating figured
out on one we'll probably have it for many more.

>
> I saw that HID interface though, and the Legion Go has one and I am
> none the wiser.
>
> I've been doing HID for over a year by now, so I am used to it.

Considering the previous experience, maybe you can help to document
their update protocol? I'm happy to collaborate on the fwupd side if
you can help push it along.

> Biggest problem is you cannot trigger an update in Windows whenever
> you want to sniff it. At least on the Lenovo.
>
> However, I think I have bigger fish to fry, so it is not high in my
> priority list.
>

AFAICT any need for this series goes away when you have an easy way to
update a handheld that is running Linux already. I would take a pile of
userspace code over kernel quirks any day.