Re: [PATCH 2/3] dt-bindings: mfd: mediatek: mt6397: add compatible for mt6359-codec

Macpaul Lin
2024-09-27T07:58:08Z

On 9/27/24 00:04, Conor Dooley wrote:
> On Thu, Sep 26, 2024 at 05:25:18PM +0800, Macpaul Lin wrote:
>> This patch updates the audio-codec properties includes:
>> - compatible:
>> - Re-order the supported device items.
>> - Add 'mt6359-codec' to compatible since MT6359 PMIC has been included
>> in this DT Schema.
>
>> - Set 'additionalProperties: true' for 'mt6359-codec'.
>
> Why?

The mt6359-codec support these 3 properties:
mediatek,mic-type0, mediatek,mic-type-1, mediatek-mic-type2.
While mt6358-sound and mt6397-codec don't (at least, I didn't find
these 3 properties in driver codes.

Set 'additionalProperties: true' is also required to fix the following
dtbs_check errors:
pmic: audio-codec: 'mediatek,mic-type-0', 'mediatek,mic-type-1',
'mediatek,mic-type-2' do not match any of the regexes:
'pinctrl-[0-9]+'

>>
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>> Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
>> index 40cabaf60d0d..ffb5848a96d5 100644
>> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
>> @@ -104,7 +104,7 @@ properties:
>>
>> audio-codec:
>> type: object
>> - additionalProperties: false
>> + additionalProperties: true
>> description:
>> Audio codec support with MT6397 and MT6358.
>>
>> @@ -112,8 +112,9 @@ properties:
>> compatible:
>> oneOf:
>> - enum:
>> - - mediatek,mt6397-codec
>> - mediatek,mt6358-sound
>> + - mediatek,mt6359-codec
>> + - mediatek,mt6397-codec
>> - items:
>> - enum:
>> - mediatek,mt6366-sound
>> --
>> 2.45.2
>>

Thanks
Macpaul Lin