Re: [PATCH 2/3] dt-bindings: mfd: mediatek: mt6397: add compatible for mt6359-codec

Macpaul Lin
2024-09-30T05:42:35Z

On 9/27/24 17:42, Krzysztof Kozlowski wrote:
>
>
> External email : Please do not click links or open attachments until you
> have verified the sender or the content.
>
> On Fri, Sep 27, 2024 at 03:57:58PM +0800, Macpaul Lin wrote:
>> On 9/27/24 00:04, Conor Dooley wrote:
>> > On Thu, Sep 26, 2024 at 05:25:18PM +0800, Macpaul Lin wrote:
>> > > This patch updates the audio-codec properties includes:
>> > > - compatible:
>> > > - Re-order the supported device items.
>> > > - Add 'mt6359-codec' to compatible since MT6359 PMIC has been included
>> > > in this DT Schema.
>> >
>> > > - Set 'additionalProperties: true' for 'mt6359-codec'.
>> >
>> > Why?
>>
>> The mt6359-codec support these 3 properties:
>> mediatek,mic-type0, mediatek,mic-type-1, mediatek-mic-type2.
>> While mt6358-sound and mt6397-codec don't (at least, I didn't find
>> these 3 properties in driver codes.
>>
>> Set 'additionalProperties: true' is also required to fix the following
>> dtbs_check errors:
>> pmic: audio-codec: 'mediatek,mic-type-0', 'mediatek,mic-type-1',
>> 'mediatek,mic-type-2' do not match any of the regexes:
>> 'pinctrl-[0-9]+'
>
> Why is this a correct fix? Aren't you allowing "pink-pony" property as
> well?
>
>>
>> > >
>> > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> > > ---
>> > > Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml | 5 +++--
>
> There is no such file.
>
> Best regards,
> Krzysztof
>

This patch is no longer necessary. I'm working on a new fix (v7)
for 'Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml' and try
to rid of these mess in audio-codec node.

Thanks
Macpaul Lin