linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org
Cc: daniel.sneddon@linux.intel.com, tony.luck@intel.com,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Brice Goglin <brice.goglin@gmail.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Perry Yuan <Perry.Yuan@amd.com>,
	Dapeng Mi <dapeng1.mi@linux.intel.com>
Subject: [PATCH v4 04/10] perf/x86/intel: Use topology_hw_cpu_type()
Date: Mon, 30 Sep 2024 07:47:37 -0700	[thread overview]
Message-ID: <20240930-add-cpu-type-v4-4-104892b7ab5f@linux.intel.com> (raw)
In-Reply-To: <20240930-add-cpu-type-v4-0-104892b7ab5f@linux.intel.com>

get_this_hybrid_cpu_type() misses a case when cpu-type is populated
regardless of X86_FEATURE_HYBRID_CPU. This is particularly true for hybrid
variants that have P or E cores fused off.

Instead use topology_hw_cpu_type() as it does not rely on hybrid feature to
enumerate cpu-type. This can also help avoid the model-specific fixup
get_hybrid_cpu_type().

Suggested-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
---
 arch/x86/events/intel/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
index d879478db3f5..80a2a307e678 100644
--- a/arch/x86/events/intel/core.c
+++ b/arch/x86/events/intel/core.c
@@ -4906,7 +4906,8 @@ static void intel_pmu_check_hybrid_pmus(struct x86_hybrid_pmu *pmu)
 
 static struct x86_hybrid_pmu *find_hybrid_pmu_for_cpu(void)
 {
-	u8 cpu_type = get_this_hybrid_cpu_type();
+	struct cpuinfo_x86 *c = &cpu_data(smp_processor_id());
+	u8 cpu_type = topology_hw_cpu_type(c);
 	int i;
 
 	/*

-- 
2.34.1



  parent reply	other threads:[~2024-09-30 14:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 14:47 [PATCH v4 00/10] Add CPU-type to topology Pawan Gupta
2024-09-30 14:47 ` [PATCH v4 01/10] x86/cpu: Prepend 0x to the hex values in cpu_debug_show() Pawan Gupta
2024-09-30 14:47 ` [PATCH v4 02/10] x86/cpu/topology: Add CPU type to struct cpuinfo_topology Pawan Gupta
2024-10-18 16:19   ` Borislav Petkov
2024-10-18 20:30     ` Pawan Gupta
2024-10-21 13:38       ` Borislav Petkov
2024-10-21 16:36         ` Pawan Gupta
2024-10-21 17:13           ` Luck, Tony
2024-10-21 17:45             ` Borislav Petkov
2024-10-21 17:59               ` Luck, Tony
2024-10-18 16:28   ` Mario Limonciello
2024-10-18 21:11     ` Pawan Gupta
2024-10-22 14:42       ` Mario Limonciello
2024-10-23  5:12         ` Pawan Gupta
2024-09-30 14:47 ` [PATCH v4 03/10] cpufreq: intel_pstate: Use topology_hw_cpu_type() Pawan Gupta
2024-09-30 14:47 ` Pawan Gupta [this message]
2024-10-21 13:54   ` [PATCH v4 04/10] perf/x86/intel: " Liang, Kan
2024-10-21 16:17     ` Pawan Gupta
2024-09-30 14:47 ` [PATCH v4 05/10] x86/cpu: Remove get_this_hybrid_cpu_type() Pawan Gupta
2024-09-30 14:47 ` [PATCH v4 06/10] x86/cpu: Name CPU matching macro more generically (and shorten) Pawan Gupta
2024-09-30 14:47 ` [PATCH v4 07/10] x86/cpu: Add cpu_type to struct x86_cpu_id Pawan Gupta
2024-09-30 14:48 ` [PATCH v4 08/10] x86/cpu: Update x86_match_cpu() to also use cpu-type Pawan Gupta
2024-09-30 14:48 ` [PATCH v4 09/10] x86/bugs: Declutter vulnerable CPU list Pawan Gupta
2024-09-30 14:48 ` [PATCH v4 10/10] x86/rfds: Exclude P-only parts from the RFDS affected list Pawan Gupta
2024-09-30 15:12 ` [PATCH v4 00/10] Add CPU-type to topology Dave Hansen
2024-09-30 22:28   ` Pawan Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240930-add-cpu-type-v4-4-104892b7ab5f@linux.intel.com \
    --to=pawan.kumar.gupta@linux.intel.com \
    --cc=Perry.Yuan@amd.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bp@alien8.de \
    --cc=brice.goglin@gmail.com \
    --cc=daniel.sneddon@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=jpoimboe@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mingo@redhat.com \
    --cc=rafael@kernel.org \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).