From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2C431DE2AD; Tue, 8 Oct 2024 12:26:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728390385; cv=none; b=mEga89UM7a1gRD2ZljIrjDp8uo8CS3RL8J6NX/NLCREatzoqZUpq817PnYQm5ZlzOjnSgF8tosgnTbg4AFTTQLkCCTm4go1Rx6ZqEHGlU0AW1H5UDHEqTmSRFxzq1og2qTMaURl3nOARz99bsVlj8Estk3YyU0v0KT11p1nEX1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728390385; c=relaxed/simple; bh=p3bcxcejmUjJNCb3MZHTGy1XXxE08A83rtDxcOF6fAg=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QRl2/OBTuLjd/iEaO+OMevU1MOj9tWO/NbwSuNa2GxqOOS9klZyht9KYK/34bYgWeObv62+PnO50G4Y+hxRvQZUpskAgKM28g1k6j1VcdZ5sLnFdNwG1W4VPPzq0mzADyz1FZY9zffECLUIqUSQdi5XGqWenXzWxPJxUEo1Mbuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XNFb717R1z6GC0b; Tue, 8 Oct 2024 20:25:07 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 908C71408F9; Tue, 8 Oct 2024 20:26:21 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 8 Oct 2024 14:26:20 +0200 Date: Tue, 8 Oct 2024 13:26:19 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski CC: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Amit Kucheria , Thara Gopinath , Thierry Reding , Jonathan Hunter , Vasily Khoruzhick , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , , , , , , , Chen-Yu Tsai Subject: Re: [PATCH v3 6/6] thermal: sun8i: Use scoped device node handling to simplify error paths Message-ID: <20241008132619.0000271c@Huawei.com> In-Reply-To: <20241008-b4-cleanup-h-of-node-put-thermal-v3-6-825122398f71@linaro.org> References: <20241008-b4-cleanup-h-of-node-put-thermal-v3-0-825122398f71@linaro.org> <20241008-b4-cleanup-h-of-node-put-thermal-v3-6-825122398f71@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To frapeml500008.china.huawei.com (7.182.85.71) On Tue, 08 Oct 2024 11:00:06 +0200 Krzysztof Kozlowski wrote: > Obtain the device node reference with scoped/cleanup.h to reduce error > handling and make the code a bit simpler. > > Reviewed-by: Chen-Yu Tsai > Signed-off-by: Krzysztof Kozlowski LGTM Reviewed-by: Jonathan Cameron I wonder if we will eventually get to the point where we might as well use the scoped case for the few remaining instances where there is no early exit and then end up dropping the unscoped one. I guess we'll see. Keep up the good work dealing with all these! Jonathan