Re: [PATCH v5 1/4] thermal/netlink: Add the commands and the events for the thresholds

Lukasz Luba
2024-10-21T19:41:49Z

Hi Daniel,

On 10/14/24 10:43, Daniel Lezcano wrote:
> The thresholds exist but there is no notification neither action code
> related to them yet.
>
> These changes implement the netlink for the notifications when the
> thresholds are crossed, added, deleted or flushed as well as the
> commands which allows to get the list of the thresholds, flush them,
> add and delete.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/thermal/thermal_netlink.c | 236 ++++++++++++++++++++++++++-
> drivers/thermal/thermal_netlink.h | 34 ++++
> drivers/thermal/thermal_thresholds.c | 36 ++--
> drivers/thermal/thermal_thresholds.h | 2 +-
> include/uapi/linux/thermal.h | 27 ++-
> 5 files changed, 307 insertions(+), 28 deletions(-)
>

Since Rafael asked to wait a bit for the other
changes to go first, I will skip the detailed review
of that patch. I will do that after you add that
new locking scheme.

In general the code looks good.

Regards,
Lukasz