From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78AEB1D432D; Thu, 17 Oct 2024 10:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729160815; cv=none; b=LZv4GBMIHnPmOH1/WV0CUvaIUFByAHBJschbOF0DnDcvqO6JBnLKf32PAUoFtIKkLZ6iAgTDkIhcyam6ek+9LNqIACQIBHwddfHSWGfX6Zym7+08Af4QV9p0PTkz8VBRsFP9nPq9NvNI4rnnVS2Wi0s7TxPl7OfwD++/NChUjbU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729160815; c=relaxed/simple; bh=FUuxvv1Dr9ZGXYdXeFFaEB5ob3Vl2U0Eilw3X2WvQ40=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VUQV+oq0bA4oX+sKZUu+P8RH7sbJDt02LAm/OI02cUHAlCU11OR8WjLFwUO0mxujHLwiqnlinQQvHb3YuL422WC1aKgWO5BBzbnd+FRbZpSTE0AFBEhmQpxu4pgMXYg9mPhngdTBN/xFxFWNNeKyfZtU0WWSrrDiUzUxOyl8DD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XTkRH0Kkzz6LDC6; Thu, 17 Oct 2024 18:22:19 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 73E9C1400C9; Thu, 17 Oct 2024 18:26:50 +0800 (CST) Received: from localhost (10.126.174.164) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 17 Oct 2024 12:26:49 +0200 Date: Thu, 17 Oct 2024 11:26:47 +0100 From: Jonathan Cameron To: Ilpo =?ISO-8859-1?Q?J=E4rvinen?= CC: , Bjorn Helgaas , "Lorenzo Pieralisi" , Rob Herring , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , "Maciej W. Rozycki" , Lukas Wunner , Alexandru Gagniuc , Krishna chaitanya chundru , Srinivas Pandruvada , "Rafael J. Wysocki" , , Smita Koralahalli , , Daniel Lezcano , Amit Kucheria , Zhang Rui , Christophe JAILLET Subject: Re: [PATCH v8 3/8] PCI: Refactor pcie_update_link_speed() Message-ID: <20241017112647.000032d8@Huawei.com> In-Reply-To: <20241009095223.7093-4-ilpo.jarvinen@linux.intel.com> References: <20241009095223.7093-1-ilpo.jarvinen@linux.intel.com> <20241009095223.7093-4-ilpo.jarvinen@linux.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To frapeml500008.china.huawei.com (7.182.85.71) On Wed, 9 Oct 2024 12:52:18 +0300 Ilpo J=E4rvinen wrote: > pcie_update_link_speed() is passed the Link Status register but not all > callers have that value at hand nor need the value. >=20 > Refactor pcie_update_link_speed() to include reading the Link Status > register and create __pcie_update_link_speed() which can be used by the > hotplug code that has the register value at hand beforehand (and needs > the value for other purposes). >=20 > Signed-off-by: Ilpo J=E4rvinen Reviewed-by: Jonathan Cameron