From: Vishnu Sanal T <t.v.s10123@gmail.com>
To: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, trenn@suse.com, shuah@kernel.org,
jwyatt@redhat.com, jkacur@redhat.com,
Vishnu Sanal T <t.v.s10123@gmail.com>
Subject: [PATCH] implement set_enabled functions on powercap.c
Date: Sat, 19 Oct 2024 18:12:34 +0530 [thread overview]
Message-ID: <20241019124233.194140-2-t.v.s10123@gmail.com> (raw)
Implement the functions sysfs_set_enabled, powercap_set_enabled,
and powercap_zone_set_enabled on powercap.c.
Signed-off-by: Vishnu Sanal T <t.v.s10123@gmail.com>
---
tools/power/cpupower/lib/powercap.c | 43 +++++++++++++++++++++++++----
1 file changed, 37 insertions(+), 6 deletions(-)
diff --git a/tools/power/cpupower/lib/powercap.c b/tools/power/cpupower/lib/powercap.c
index 94a0c69e55ef..1cf2b0de5536 100644
--- a/tools/power/cpupower/lib/powercap.c
+++ b/tools/power/cpupower/lib/powercap.c
@@ -70,6 +70,29 @@ static int sysfs_get_enabled(char *path, int *mode)
return ret;
}
+static int sysfs_set_enabled(char *path, int mode)
+{
+ int fd;
+ char yes_no = (char) (mode + '0');
+ int ret = 0;
+
+ fd = open(path, O_RDWR);
+ if (fd == -1) {
+ ret = -1;
+ goto out;
+ }
+
+ if (write(fd, &yes_no, 1) != 1) {
+ ret = -1;
+ goto out_close;
+ }
+
+out_close:
+ close(fd);
+out:
+ return ret;
+}
+
int powercap_get_enabled(int *mode)
{
char path[SYSFS_PATH_MAX] = PATH_TO_POWERCAP "/intel-rapl/enabled";
@@ -77,12 +100,11 @@ int powercap_get_enabled(int *mode)
return sysfs_get_enabled(path, mode);
}
-/*
- * TODO: implement function. Returns dummy 0 for now.
- */
int powercap_set_enabled(int mode)
{
- return 0;
+ char path[SYSFS_PATH_MAX] = PATH_TO_POWERCAP "/intel-rapl/enabled";
+
+ return sysfs_set_enabled(path, mode);
}
/*
@@ -180,8 +202,17 @@ int powercap_zone_get_enabled(struct powercap_zone *zone, int *mode)
int powercap_zone_set_enabled(struct powercap_zone *zone, int mode)
{
- /* To be done if needed */
- return 0;
+ char path[SYSFS_PATH_MAX] = PATH_TO_POWERCAP;
+
+ if ((strlen(PATH_TO_POWERCAP) + strlen(zone->sys_name)) +
+ strlen("/enabled") + 1 >= SYSFS_PATH_MAX)
+ return -1;
+
+ strcat(path, "/");
+ strcat(path, zone->sys_name);
+ strcat(path, "/enabled");
+
+ return sysfs_set_enabled(path, mode);
}
--
2.47.0
next reply other threads:[~2024-10-19 12:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 12:42 Vishnu Sanal T [this message]
2024-10-21 20:36 ` [PATCH] implement set_enabled functions on powercap.c Shuah Khan
2024-10-30 15:27 ` [PATCH v2] " Vishnu Sanal T
2024-10-30 16:57 ` John B. Wyatt IV
2024-11-03 16:27 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241019124233.194140-2-t.v.s10123@gmail.com \
--to=t.v.s10123@gmail.com \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).