From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C03F3205E37 for ; Tue, 12 Nov 2024 06:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731393845; cv=none; b=JKGEHwIcZ7SIDNZRGBBNj9fzVVWJaiBtPZDCi/7lDdmjR0HHb3qwnySuLVzwalzjg4bsYycofl8fobNYGsUO8heBb/ccnteCyrNxS9xCsQHDfJ4gOGU4+HZD24DynDT4kgWYgApVR53F8wdBjY7HGyn/FIHb6Nt9EDbkDSJq61E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731393845; c=relaxed/simple; bh=FY6WFOJXqCfbzedEEbqnXaBCPjvQ/+RzjiOySYoM/Lk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l1rZm7nWOEueC/hNfiKHM8jFTSJeCSkr9IAmme5AaDHPwfo58DaZVYErY47xyGVljWYhgjLSloqL1YzsEnZoJLiiSkLSgCZJid3zkG2C1seFAlTHLD9q1fAdGlibkCAdfYJ29s0eFnO6bp1hANr8wzPAvoSq4wbdw7XapiT5sFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NSlZdqE7; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NSlZdqE7" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-71e5a62031aso4120934b3a.1 for ; Mon, 11 Nov 2024 22:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731393843; x=1731998643; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JPlc0iWn23rPv1Yelqqb+UADsrKyk5eLdXjS43qvnhE=; b=NSlZdqE7owQlczD41Q00zD6PwMCU+CZ5tWA8IoplXkNgDsmgv3AW7bgXJDhHzPM5iL PgcmtnDRzO+ZrC9uR2jV2BdXJ8KfKkFwAbe+LJkQ5XSPOIG+yX4ACoDproJ/wFr9HDr5 ez0EQDg0Tjr9g4TBL0yonNTBUjTygatx0/aeEWtSVsS8VGXrzJy/53XSwUJ2LQespSy4 gDyaffp15tE5lgjwbpJIPnUAY/aBRRwI9VduLsCOQMt1vM+/giSWUCn3V2BQzp5b/wRv /+0MPIr3yfsvXSEGAFONLMKEPgBS9woB76ZK35rbfvth1z8qYFN65FTH0QmavhYs3Qm2 Uevg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731393843; x=1731998643; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JPlc0iWn23rPv1Yelqqb+UADsrKyk5eLdXjS43qvnhE=; b=MmR9+4hWnx9NvM4QF0RtbYAIOh6F7bteJkMaJrOY9HVBU2RzKSGZTioUpfBTyNP1yD i/7J89U4TKDX5KRA0o75pI95S3hIKlqcToJMiApSz3PNvbwEDuLMQzw63CVINSk9LCL/ Drf7HVqf59tg7lEI6hewfbb+IzZ7ln6m5sd/oxINqz+l83yt/FV3aDA0MBx26H4vlvne J4CLykL6z1OeYwNYbGz9A3VVRMDl4GzXxn9ZOS8mQKjIflqgl7733pg6jMcOywurc+sK jwsoGJY8+eWUnnQa3OhIBI+kyVXsaqz7OYsw/DExG1DvEQi9OpKqcS6RaBPC/vOb4G2E W/mQ== X-Forwarded-Encrypted: i=1; AJvYcCU5dui/BvDHTiIjN2U8GRIkFL8Sn2Xng5vDFJFKisT52tmSzVCbVPj2PCTtQ8/Dw/pc9xTapvsdVw==@vger.kernel.org X-Gm-Message-State: AOJu0Ywjcli8SPCh8vige2LJDmySViA9yXFjkogb9loOUhVwc2FcYLep JG+nxqYX85uwt2a71IENSxBvYIj0MvyaEHQicnS7NdD1nNHQfPj12pHA0mYb/A== X-Google-Smtp-Source: AGHT+IFK7EbTW8j6RbaesACTxS+4wyWWBFBogZmLwWGxzhBM+sg2NEDsPKsDx80UIoPC1dThJW6KHg== X-Received: by 2002:a05:6a20:2d1f:b0:1db:e90a:6b24 with SMTP id adf61e73a8af0-1dc22985104mr21818819637.25.1731393843104; Mon, 11 Nov 2024 22:44:03 -0800 (PST) Received: from thinkpad ([117.213.103.248]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7240799bb78sm10282483b3a.95.2024.11.11.22.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2024 22:44:02 -0800 (PST) Date: Tue, 12 Nov 2024 12:13:54 +0530 From: Manivannan Sadhasivam To: Shawn Lin Cc: Rob Herring , "James E . J . Bottomley" , "Martin K . Petersen" , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Heiko Stuebner , "Rafael J . Wysocki" , Alim Akhtar , Avri Altman , Bart Van Assche , YiFeng Zhao , Liang Chen , linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v4 7/7] scsi: ufs: rockchip: initial support for UFS Message-ID: <20241112064354.g634ca5w2gagfyko@thinkpad> References: <1730705521-23081-1-git-send-email-shawn.lin@rock-chips.com> <1730705521-23081-8-git-send-email-shawn.lin@rock-chips.com> <20241109121249.vncqbacvpnpf6d34@thinkpad> <13ad21bb-9f5a-4a4b-8b65-55243f6fe817@rock-chips.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <13ad21bb-9f5a-4a4b-8b65-55243f6fe817@rock-chips.com> On Mon, Nov 11, 2024 at 09:10:39AM +0800, Shawn Lin wrote: [...] > > > +static void ufs_rockchip_remove(struct platform_device *pdev) > > > +{ > > > + struct ufs_hba *hba = platform_get_drvdata(pdev); > > > + struct ufs_rockchip_host *host = ufshcd_get_variant(hba); > > > + > > > + pm_runtime_forbid(&pdev->dev); > > > + pm_runtime_get_noresume(&pdev->dev); > > > > Why do you need these? You are not incrementing the refcount in probe() and > > there is no auto PM involved. > > Oh, it was a leftover from former version I haven't noticed. Will > remove. > I've sent a series [1] that addresses the runtime PM issues. Could you please give it a try and give your tested-by maybe? - Mani [1] https://lore.kernel.org/linux-scsi/20241111-ufs_bug_fix-v1-0-45ad8b62f02e@linaro.org/ -- மணிவண்ணன் சதாசிவம்