From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0872F2063DE for ; Mon, 16 Dec 2024 16:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734367719; cv=none; b=j8grrPrHWIbckkH7a5uaL7Sp7Yvbcy8C4M3Xoc9WzIWUsczv/t7i6MC5OhIc7sdXAdAkSj0/PTlzVp4j6P+j6kSXz+mfZI7nCsXz83BL/xVU4W+M6utqgLOdSi7ZaQiAO1nA2YyzgnTb5CEvBWI+KK5B3pLWNeVoEQkpnPIXIiM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734367719; c=relaxed/simple; bh=JVy1OakhjRBLAdA6bfdtQVTG5Be/+QvYNXigpOHTD3Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TiPaiR67pgDRElfjjySIszCbi9CGJJPJhQPJoiWsDtjNXqXZdQZvCFaCLhlbrt4TNaI3oapYZ+LA96wlwi/7pKo/yhgie/XP6oZ14MoamH6pJeVNMnxABPSaCrN/fXh7SUvV9nI1st0aW0xWXH50aAfBBbAmcm39VhmxwJYj2gU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wk6qB7Kf; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wk6qB7Kf" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-21628b3fe7dso33682205ad.3 for ; Mon, 16 Dec 2024 08:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734367717; x=1734972517; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=uf/C35BwQBTRlT0IeaFUKw9xJGt6H8iM2xKqt61L0Gc=; b=wk6qB7KfcPA62V34D7l/DQce+iYDhcODPnDK0/4cySZmO4TrlaCXZh6wy3Fii1Pum0 CciDHmoWb0mbaCX6Y2wM+bkPDxagvGX0rIDC3peMWGU0N4kUA5Rl2MWhWC2HZxMgwUJZ 4LoRX+uG7fJogSX//RB6GljG/9/9sy8A0q+ERPfTfg7VjuXuj3yblWqOlhvmONaq0EF5 TXumy8N5yJ7Uj6BzkL6hfUITNAUqGKT9QrKjUsPOAmiMP0EjC+jx8EI9L0mLged1hHAl ej7bsb9yjodB85tF2iNX3dD829cLRwcSEerKqK6x8FvG+O/VYB7L4R3AkrHni7PGf9Lk tZTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734367717; x=1734972517; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uf/C35BwQBTRlT0IeaFUKw9xJGt6H8iM2xKqt61L0Gc=; b=ntf1AeBdthU6+ezw5snGSbFhcDLkbwYAtrXYVEZ+JgOsjvDWxEzswbBKyom5gvdVll I0I4IC/V8BwsiitZp+x/4qwga4iFpf1UsGtF4MxLpTVIOe0+z2w1A7TrXI+NPRhA2yGl 4Q05Oe+nbAHFLofvNhHo2zsADxM5jfO/BDPGd1xyldGjaz3gORGHdN3siEikdkWp+HXA 67kGIT+nLmkyVfzipd+roCE5b4sNpE+AoccQCYAP0rQ6h4tQQgsTJHMk3PPbE2HKkfnN 7PDqqwelKxAbqThiQzumcgreXYFtlQ4V+mGk42/SuEK69vTZW5H5g8a4Jgxil/sGaAMH 1zPg== X-Forwarded-Encrypted: i=1; AJvYcCU5bEgwXnfABaeinp+q3ZbzkbD6qrsNgreFD4y2zAAk1evMsG6SFGVBVSWPHZv8OZ/fQ94icFO+vg==@vger.kernel.org X-Gm-Message-State: AOJu0YweksYC6xhR8NopsvpPhtgHhqcZzVviH1nsbiIvw7+pDrJkNb/4 bk1zq/yNYnRJLCT3ffqEOt+Gi9z/eF8LUX0Kl0s0UD3yqsH+KLwjrr51d5YLig== X-Gm-Gg: ASbGnct02z5oWfnkgg4bLfAN73/2VpE/jNRn9wCW0DHIQ10UFkX/ySopBbpzlYblc4j HgmwdWzPdhOKRYqhMj3hH/pJ+qCAMHtKJq+JuAUwcK23vXXiR1wjhGWUTwUPGTZChJlUTqKe2HN uV1K66QRlY3NHpeLoznaz+xFTUFwe5dNkVz9pHoBZ0Z0JP2X7NkpckqhfgJFq5zcB+YR9oUYRQC M2lexziQeElS+3nMWl31FJJikAzyc4jH1mAwAGDicET+0lOMQJoRSrxWT2Nxhf854wR X-Google-Smtp-Source: AGHT+IEbjZhCC60l4mXiJWyw0YJq9ctEYxooGkv/o7bOg9yFa29PqtrzXCLZoknekW9tg22tCtP5pg== X-Received: by 2002:a17:902:ccd2:b0:216:26f1:530b with SMTP id d9443c01a7336-21892a70579mr183783695ad.51.1734367717333; Mon, 16 Dec 2024 08:48:37 -0800 (PST) Received: from thinkpad ([120.56.200.168]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e510a9sm44948185ad.167.2024.12.16.08.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 08:48:36 -0800 (PST) Date: Mon, 16 Dec 2024 22:18:30 +0530 From: Manivannan Sadhasivam To: "Rafael J. Wysocki" Cc: Christoph Hellwig , Ulf Hansson , "Rafael J. Wysocki" , Bjorn Helgaas , kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, Len Brown , linux-pm@vger.kernel.org Subject: Re: [PATCH] nvme-pci: Shutdown the device if D3Cold is allowed by the user Message-ID: <20241216164830.36lpu6gfnapsdar4@thinkpad> References: <20241205232900.GA3072557@bhelgaas> <20241209143821.m4dahsaqeydluyf3@thinkpad> <20241212055920.GB4825@lst.de> <13662231.uLZWGnKmhe@rjwysocki.net> <20241212151354.GA7708@lst.de> <20241214063023.4tdvjbqd2lrylb7o@thinkpad> <20241216162303.GA26434@lst.de> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Dec 16, 2024 at 05:42:30PM +0100, Rafael J. Wysocki wrote: > On Mon, Dec 16, 2024 at 5:23 PM Christoph Hellwig wrote: > > > > On Sat, Dec 14, 2024 at 12:00:23PM +0530, Manivannan Sadhasivam wrote: > > > We need a PM core API that tells the device drivers when it is safe to powerdown > > > the devices. The usecase here is with PCIe based NVMe devices but the problem is > > > applicable to other devices as well. > > > > Maybe I'm misunderstanding things, but I think the important part is > > to indicate when a suspend actually MUST put the device into D3. Because > > doing that should always be safe, but not always optimal. > > I'm not aware of any cases when a device must be put into D3cold > (which I think is what you mean) during system-wide suspend. > > Suspend-to-idle on x86 doesn't require this, at least not for > correctness. I don't think any platforms using DT require it either. > On suspend-to-idle, yes D3Cold doesn't make sense, but on suspend-to-ram it is pretty much required. That applies to DT as well. - Mani -- மணிவண்ணன் சதாசிவம்