Re: [PATCH 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC

[Pengyu Luo <mitltlatltl@gmail.com>]

On Sun, Dec 29, 2024 at 5:50 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 28/12/2024 11:50, Pengyu Luo wrote:
> > On Sat, Dec 28, 2024 at 5:54 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >> On 27/12/2024 18:13, Pengyu Luo wrote:
> >>> +
> >>> +description:
> >>> +  Different from other Qualcomm Snapdragon sc8180x sc8280xp based machines,
> >>> +  the Huawei Matebook E Go tablets use embedded controllers while others
> >>> +  use something called pmic glink which handles battery, UCSI, USB Type-C DP
> >>> +  alt mode. Huawei one handles even more, like charging thresholds, FN lock,
> >>> +  lid status, HPD events for the USB Type-C DP alt mode, etc.
> >>> +
> >>> +properties:
> >>> +  compatible:
> >>> +    items:
> >>> +      - enum:
> >>> +          - huawei,sc8180x-gaokun-ec
> >>> +          - huawei,sc8280xp-gaokun-ec
> >>
> >> sc8180x and sc8280xp are not products of Huawei, so you cannot combine
> >> them. Use compatibles matching exactly your device, because I doubt any
> >> of us has actual schematics or datasheet of that device.
> >>
> >>> +      - const: huawei,gaokun-ec
> >>
> >> How did you get the name?
> >>
> >
> > From website of Huawei([1]), please search for 'gaokun' here, we can know
>
> Then please explain this in commit msg or bindings description (what is
> gaokun).
>

I will add it in v2.

> > this series is called gaokun. Many files from windows indicate more,
> > someone fetch drivers from microsoft server([2]), in one of driver archive
> > 'OemXAudioExt_HWVE.cab', there are two files, "algorithm_GaoKunGen2.xml"
> > "algorithm_GaoKunGen3.xml". And `Gaokun Gen3` print can be found on
> > motherboard(someone have the motherboard, I can ask for it later).
> >
> > So can I use?
> > - enum:
> >       - huawei,gaokun-gen2
> >       - huawei,gaokun-gen3
>
> The internal name?
>
> >
> > Some backgroud:
> > There are 3 variants, Huawei released first 2 at the same time.
> > Huawei Matebook E Go LTE(sc8180x), codename should be gaokun2.
> > Huawei Matebook E Go(sc8280xp@3.0GHz), codename is gaokun3.
> > Huawei Matebook E Go 2023(sc8280xp@2.69GHz).
>
> Well, I believe it is still not good choice because we have absolutely
> zero insights what is actually there, what else is called gaokun etc.
> Especially "gen2" and "gen3" - how can anyone, outside of Huawei, figure
> out which is gen3?
>
> Why do people try to decode some vendor naming scheme instead of using
> well recognized, public and available naming: the device name?
>

Check the motherboard, https://postimg.cc/V5r4KCgx (Credit to Tianyu Gao <gty0622@gmail.com>)
Gen3 must be sc8280xp based variants. There are many clues showing that
sc8180x based variant is Gen2. I don't want to decode anything, but as you
also review Documentation/devicetree/bindings/arm/qcom.yaml, most of them
are suggest to use a codename, the retailer name is so long and confused.


Best wishes,
Pengyu