Re: [PATCH 2/2] power: supply: add LT8491 battery charger driver

[kernel test robot <lkp@intel.com>]

Hi John,

kernel test robot noticed the following build warnings:

[auto build test WARNING on a3a8799165ff83bb764fd800c6559c3cba0ddac3]

url:    https://github.com/intel-lab-lkp/linux/commits/John-Erasmus-Mari-Geronimo/dt-bindings-power-supply-add-adi-lt8491-yaml/20250110-160441
base:   a3a8799165ff83bb764fd800c6559c3cba0ddac3
patch link:    https://lore.kernel.org/r/20250110080235.54808-3-johnerasmusmari.geronimo%40analog.com
patch subject: [PATCH 2/2] power: supply: add LT8491 battery charger driver
config: sparc64-randconfig-r071-20250114 (https://download.01.org/0day-ci/archive/20250115/202501150030.cWwtcIoo-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501150030.cWwtcIoo-lkp@intel.com/

smatch warnings:
drivers/power/supply/lt8491_charger.c:66 lt8491_read_serial_number() warn: unsigned 'serial_number[i]' is never less than zero.

vim +66 drivers/power/supply/lt8491_charger.c

    57	
    58	static int lt8491_read_serial_number(struct lt8491_info *info)
    59	{
    60		int i, ret;
    61		u32 serial_number[LT8491_MFR_DATA_LEN];
    62	
    63		for (i = 0; i < LT8491_MFR_DATA_LEN; i++) {
    64			serial_number[i] = i2c_smbus_read_word_data(info->client,
    65						LT8491_MFR_DATA1_LSB_REG + i * 2);
  > 66			if (serial_number[i] < 0)
    67				return serial_number[i];
    68		}
    69	
    70		ret = sprintf(info->serial_number, "%04x%04x%04x", serial_number[0],
    71			      serial_number[1], serial_number[2]);
    72		if (ret < 0)
    73			return ret;
    74	
    75		return 0;
    76	}
    77	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki