From: Sudeep Holla <sudeep.holla@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Cristian Marussi <cristian.marussi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Lifeng Zheng <zhenglifeng1@huawei.com>,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/15] cpufreq: scmi: Set .set_boost directly
Date: Tue, 28 Jan 2025 11:27:01 +0000 [thread overview]
Message-ID: <20250128112701.s2kgegovz625nuac@bogus> (raw)
In-Reply-To: <ec27aef491c1b71ef5f1240480c52d051cdd821d.1737707712.git.viresh.kumar@linaro.org>
On Fri, Jan 24, 2025 at 02:28:15PM +0530, Viresh Kumar wrote:
> The boost feature can be controlled at two levels currently, driver
> level (applies to all policies) and per-policy.
>
> Currently the driver enables driver level boost support from the
> per-policy ->init() callback, which isn't really efficient as that gets
> called for each policy and then there is online/offline path too where
> this gets done unnecessarily.
>
> Instead set the .set_boost field directly and always enable the boost
> support. If a policy doesn't support boost feature, the core will not
> enable it for that policy.
>
> Keep the initial state of driver level boost to disabled and let the
> user enable it if required as ideally the boost frequencies must be used
> only when really required.
>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
next prev parent reply other threads:[~2025-01-28 11:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 8:58 [PATCH 00/15] cpufreq: simplify boost handling Viresh Kumar
2025-01-24 8:58 ` [PATCH 01/15] cpufreq: staticize cpufreq_boost_trigger_state() Viresh Kumar
2025-01-24 8:58 ` [PATCH 02/15] cpufreq: Export cpufreq_boost_set_sw() Viresh Kumar
2025-01-24 8:58 ` [PATCH 03/15] cpufreq: Introduce policy->boost_supported flag Viresh Kumar
2025-01-24 8:58 ` [PATCH 04/15] cpufreq: acpi: Set policy->boost_supported Viresh Kumar
2025-01-24 8:58 ` [PATCH 05/15] cpufreq: amd: " Viresh Kumar
2025-01-30 9:15 ` Dhananjay Ugwekar
2025-01-24 8:58 ` [PATCH 06/15] cpufreq: cppc: " Viresh Kumar
2025-02-06 3:58 ` zhenglifeng (A)
2025-02-06 5:27 ` Viresh Kumar
2025-02-06 6:27 ` zhenglifeng (A)
2025-01-24 8:58 ` [PATCH 07/15] cpufreq: Restrict enabling boost on policies with no boost frequencies Viresh Kumar
2025-01-24 8:58 ` [PATCH 08/15] cpufreq: apple: Set .set_boost directly Viresh Kumar
2025-01-24 8:58 ` [PATCH 09/15] cpufreq: loongson: " Viresh Kumar
2025-01-24 8:58 ` [PATCH 10/15] cpufreq: powernv: " Viresh Kumar
2025-01-24 8:58 ` [PATCH 11/15] cpufreq: scmi: " Viresh Kumar
2025-01-28 11:27 ` Sudeep Holla [this message]
2025-01-24 8:58 ` [PATCH 12/15] cpufreq: dt: " Viresh Kumar
2025-01-24 8:58 ` [PATCH 13/15] cpufreq: qcom: " Viresh Kumar
2025-01-24 8:58 ` [PATCH 14/15] cpufreq: staticize policy_has_boost_freq() Viresh Kumar
2025-01-24 8:58 ` [PATCH 15/15] cpufreq: Remove cpufreq_enable_boost_support() Viresh Kumar
2025-01-24 11:05 ` [PATCH 00/15] cpufreq: simplify boost handling Rafael J. Wysocki
2025-01-27 3:32 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128112701.s2kgegovz625nuac@bogus \
--to=sudeep.holla@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=zhenglifeng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox