From: Jennifer Berringer <jberring@redhat.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Sebastian Reichel <sre@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Jennifer Berringer <jberring@redhat.com>
Subject: [PATCH v4 0/2] nvmem-reboot-mode: support small reboot mode magic
Date: Fri, 28 Feb 2025 13:03:24 -0500 [thread overview]
Message-ID: <20250228180326.256058-1-jberring@redhat.com> (raw)
Hi all,
These patches allow nvmem-reboot-mode to handle devices with a
reboot-mode cell smaller than 4 bytes, such as Qualcomm SA8775P. Without
this change, nvmem_reboot_mode_write() tries to write 4 bytes to a
1-byte nvmem cell and fails with the message "update reboot mode bits
failed" on affected devices.
This issue previously resulted in an out-of-bounds heap write but, after
one of my patches from v3 of this series was accepted, it results in
that error message instead.
[1]
https://lore.kernel.org/all/20241104152312.3813601-2-jberring@redhat.com/
v4:
- Excluded one patch which was accepted from v3 [1]:
"nvmem: core: improve range check for nvmem_cell_write()"
- Handle truncation of the reboot mode magic in nvmem-reboot-mode
instead of in nvmem core.
- Introduced nvmem_cell_size().
v3:
- Accepted suggestion for changing nvmem_cell_write bounds check
v2:
- Added missing function definition for CONFIG_NVMEM=n
Jennifer Berringer (2):
nvmem: core: add nvmem_cell_size()
power: reset: nvmem-reboot-mode: support smaller magic
drivers/nvmem/core.c | 18 ++++++++++++++++++
drivers/power/reset/nvmem-reboot-mode.c | 9 ++++++++-
include/linux/nvmem-consumer.h | 6 ++++++
3 files changed, 32 insertions(+), 1 deletion(-)
base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
--
2.47.1
next reply other threads:[~2025-02-28 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 18:03 Jennifer Berringer [this message]
2025-02-28 18:03 ` [PATCH v4 1/2] nvmem: core: add nvmem_cell_size() Jennifer Berringer
2025-03-07 17:42 ` Srinivas Kandagatla
2025-03-08 4:38 ` Jennifer Berringer
2025-02-28 18:03 ` [PATCH v4 2/2] power: reset: nvmem-reboot-mode: support smaller magic Jennifer Berringer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228180326.256058-1-jberring@redhat.com \
--to=jberring@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox