From: Jacky Bai <ping.bai@nxp.com>
To: lpieralisi@kernel.org, sudeep.holla@arm.com, rafael@kernel.org,
ulf.hansson@linaro.org, daniel.lezcano@linaro.org,
james.morse@arm.com, d-gole@ti.com
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
khilman@baylibre.com, quic_tingweiz@quicinc.com,
quic_yuanjiey@quicinc.com
Subject: [PATCH v3] cpuidle: psci: Init cpuidle only for present CPUs
Date: Thu, 6 Mar 2025 14:18:05 +0800 [thread overview]
Message-ID: <20250306061805.2318154-1-ping.bai@nxp.com> (raw)
for_each_possible_cpu() is currently used to initialize cpuidle
in the PSCI cpuidle driver.
However, in cpu_dev_register_generic(), for_each_present_cpu()
is used to register CPU devices which means the CPU devices are
only registered for present CPUs and not all possible CPUs.
With nosmp or maxcpus=0, only the boot CPU is present, leading
to the failure:
| Failed to register cpuidle device for cpu1
Change for_each_possible_cpu() to for_each_present_cpu() in the
PSCI cpuidle driver to ensure it only registers cpuidle devices
for CPUs that are actually present.
Fixes: b0c69e1214bc ("drivers: base: Use present CPUs in GENERIC_CPU_DEVICES")
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Tested-by: Yuanjie Yang <quic_yuanjiey@quicinc.com>
Signed-off-by: Jacky Bai <ping.bai@nxp.com>
---
- v2 changes:
- Improve the changelog as suggested by Sudeep
---
drivers/cpuidle/cpuidle-psci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle-psci.c b/drivers/cpuidle/cpuidle-psci.c
index 2562dc001fc1..00117e9b33e8 100644
--- a/drivers/cpuidle/cpuidle-psci.c
+++ b/drivers/cpuidle/cpuidle-psci.c
@@ -410,7 +410,7 @@ static int psci_cpuidle_probe(struct platform_device *pdev)
struct cpuidle_driver *drv;
struct cpuidle_device *dev;
- for_each_possible_cpu(cpu) {
+ for_each_present_cpu(cpu) {
ret = psci_idle_init_cpu(&pdev->dev, cpu);
if (ret)
goto out_fail;
--
2.34.1
next reply other threads:[~2025-03-06 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 6:18 Jacky Bai [this message]
2025-03-06 10:53 ` [PATCH v3] cpuidle: psci: Init cpuidle only for present CPUs Ulf Hansson
2025-03-06 12:42 ` Sudeep Holla
2025-03-07 2:33 ` Jacky Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306061805.2318154-1-ping.bai@nxp.com \
--to=ping.bai@nxp.com \
--cc=d-gole@ti.com \
--cc=daniel.lezcano@linaro.org \
--cc=imx@lists.linux.dev \
--cc=james.morse@arm.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_yuanjiey@quicinc.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox