Linux Power Management development
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jelle van der Waa <jvanderw@redhat.com>,
	Sebastian Reichel <sre@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	"Hans de Goede" <hdegoede@redhat.com>,
	linux-pm@vger.kernel.org,
	"Jelle van der Waa" <jvanderwaa@redhat.com>
Subject: Re: [PATCH 1/1] power: supply: support charge_types in extensions
Date: Wed, 9 Apr 2025 10:11:24 +0800	[thread overview]
Message-ID: <202504090859.yXF0zkoj-lkp@intel.com> (raw)
In-Reply-To: <20250407201845.332348-2-jvanderw@redhat.com>

Hi Jelle,

kernel test robot noticed the following build warnings:

[auto build test WARNING on sre-power-supply/for-next]
[also build test WARNING on linus/master v6.15-rc1 next-20250408]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jelle-van-der-Waa/power-supply-support-charge_types-in-extensions/20250408-045501
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
patch link:    https://lore.kernel.org/r/20250407201845.332348-2-jvanderw%40redhat.com
patch subject: [PATCH 1/1] power: supply: support charge_types in extensions
config: csky-randconfig-001-20250409 (https://download.01.org/0day-ci/archive/20250409/202504090859.yXF0zkoj-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250409/202504090859.yXF0zkoj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504090859.yXF0zkoj-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/power/supply/test_power.c: In function 'test_power_battery_property_is_writeable':
>> drivers/power/supply/test_power.c:148:20: warning: suggest parentheses around comparison in operand of '|' [-Wparentheses]
     148 |         return psp == POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR | POWER_SUPPLY_PROP_CHARGE_TYPES;
         |                ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +148 drivers/power/supply/test_power.c

   144	
   145	static int test_power_battery_property_is_writeable(struct power_supply *psy,
   146							    enum power_supply_property psp)
   147	{
 > 148		return psp == POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR | POWER_SUPPLY_PROP_CHARGE_TYPES;
   149	}
   150	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      parent reply	other threads:[~2025-04-09  2:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 20:18 [PATCH 0/1] support charge_types in the extensions API Jelle van der Waa
2025-04-07 20:18 ` [PATCH 1/1] power: supply: support charge_types in extensions Jelle van der Waa
2025-04-08  8:07   ` Hans de Goede
2025-04-08 23:03   ` kernel test robot
2025-04-09  2:11   ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202504090859.yXF0zkoj-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=jvanderw@redhat.com \
    --cc=jvanderwaa@redhat.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox