[rafael-pm:bleeding-edge 44/52] drivers/cpuidle/cpuidle-psci.c:437:54: error: expected identifier

[rafael-pm:bleeding-edge 44/52] drivers/cpuidle/cpuidle-psci.c:437:54: error: expected identifier

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head:   605857f6c52205d83a7963edbdfaaa307ee7bde4
commit: a60e3d71e4d49a9be9fa5fc3cb9c4942e29fd934 [44/52] cpuidle: psci: Transition to the faux device interface
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250412/202504121050.dgHmFeWe-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250412/202504121050.dgHmFeWe-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504121050.dgHmFeWe-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/cpuidle/cpuidle-psci.c:437:54: error: expected identifier
     437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
         |                                                      ^
   include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
       8 | #define NULL ((void *)0)
         |              ^
>> drivers/cpuidle/cpuidle-psci.c:437:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
         | ^
         | int
>> drivers/cpuidle/cpuidle-psci.c:437:19: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
     437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
         |                   ^                                            
         |                                                                void
   3 errors generated.


vim +437 drivers/cpuidle/cpuidle-psci.c

   436	
 > 437	module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [rafael-pm:bleeding-edge 44/52] drivers/cpuidle/cpuidle-psci.c:437:54: error: expected identifier

[Sudeep Holla]

Hi Rafael,

On Sat, Apr 12, 2025 at 10:36:41AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> 

[...]

> >> drivers/cpuidle/cpuidle-psci.c:437:54: error: expected identifier
>      437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
>          |                                                      ^
>    include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
>        8 | #define NULL ((void *)0)
>          |              ^
> >> drivers/cpuidle/cpuidle-psci.c:437:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
>      437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
>          | ^
>          | int
> >> drivers/cpuidle/cpuidle-psci.c:437:19: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
>      437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
>          |                   ^                                            
>          |                                                                void
>    3 errors generated.
> 
> 
> vim +437 drivers/cpuidle/cpuidle-psci.c
> 
>    436	
>  > 437	module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
> 

I think you asked me correctly on v1 [1] to pick up, but I assume with
patchwork, may be you picked up v2 instead. The link in the commit log is
pointing at v2.

-- 
Regards,
Sudeep

[1] https://lore.kernel.org/all/20250317-plat2faux_dev-v1-1-5fe67c085ad5@arm.com/

Re: [rafael-pm:bleeding-edge 44/52] drivers/cpuidle/cpuidle-psci.c:437:54: error: expected identifier

[Rafael J. Wysocki]

Hi Sudeep,

On Sun, Apr 13, 2025 at 5:01 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> Hi Rafael,
>
> On Sat, Apr 12, 2025 at 10:36:41AM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> >
>
> [...]
>
> > >> drivers/cpuidle/cpuidle-psci.c:437:54: error: expected identifier
> >      437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
> >          |                                                      ^
> >    include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> >        8 | #define NULL ((void *)0)
> >          |              ^
> > >> drivers/cpuidle/cpuidle-psci.c:437:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
> >      437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
> >          | ^
> >          | int
> > >> drivers/cpuidle/cpuidle-psci.c:437:19: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
> >      437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
> >          |                   ^
> >          |                                                                void
> >    3 errors generated.
> >
> >
> > vim +437 drivers/cpuidle/cpuidle-psci.c
> >
> >    436
> >  > 437        module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
> >
>
> I think you asked me correctly on v1 [1] to pick up, but I assume with
> patchwork, may be you picked up v2 instead. The link in the commit log is
> pointing at v2.
>
> [1] https://lore.kernel.org/all/20250317-plat2faux_dev-v1-1-5fe67c085ad5@arm.com/

Yeah, I've applied the v1 now, thanks!