Linux Power Management development
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: kernel test robot <lkp@intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	Sudeep Holla <sudeep.holla@arm.com>,
	linux-acpi@vger.kernel.org, devel@acpica.org,
	linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [rafael-pm:bleeding-edge 44/52] drivers/cpuidle/cpuidle-psci.c:437:54: error: expected identifier
Date: Sun, 13 Apr 2025 16:00:57 +0100	[thread overview]
Message-ID: <20250413-brawny-certain-bullmastiff-da71fa@sudeepholla> (raw)
In-Reply-To: <202504121050.dgHmFeWe-lkp@intel.com>

Hi Rafael,

On Sat, Apr 12, 2025 at 10:36:41AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
> 

[...]

> >> drivers/cpuidle/cpuidle-psci.c:437:54: error: expected identifier
>      437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
>          |                                                      ^
>    include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
>        8 | #define NULL ((void *)0)
>          |              ^
> >> drivers/cpuidle/cpuidle-psci.c:437:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
>      437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
>          | ^
>          | int
> >> drivers/cpuidle/cpuidle-psci.c:437:19: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
>      437 | module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
>          |                   ^                                            
>          |                                                                void
>    3 errors generated.
> 
> 
> vim +437 drivers/cpuidle/cpuidle-psci.c
> 
>    436	
>  > 437	module_faux_driver(psci_cpuidle, psci_cpuidle_probe, NULL, true);
> 

I think you asked me correctly on v1 [1] to pick up, but I assume with
patchwork, may be you picked up v2 instead. The link in the commit log is
pointing at v2.

-- 
Regards,
Sudeep

[1] https://lore.kernel.org/all/20250317-plat2faux_dev-v1-1-5fe67c085ad5@arm.com/

  reply	other threads:[~2025-04-13 15:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-12  2:36 [rafael-pm:bleeding-edge 44/52] drivers/cpuidle/cpuidle-psci.c:437:54: error: expected identifier kernel test robot
2025-04-13 15:00 ` Sudeep Holla [this message]
2025-04-14 14:46   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250413-brawny-certain-bullmastiff-da71fa@sudeepholla \
    --to=sudeep.holla@arm.com \
    --cc=devel@acpica.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox