Linux Power Management development
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	x86 Maintainers <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux PM <linux-pm@vger.kernel.org>, Len Brown <lenb@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@suse.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
	Ingo Molnar <mingo@redhat.com>,
	Todd Brandt <todd.e.brandt@linux.intel.com>
Subject: Re: [PATCH v1 0/2] x86/smp: Fix power regression introduced by commit 96040f7273e2
Date: Fri, 30 May 2025 10:07:33 +0200	[thread overview]
Message-ID: <20250530080733.GH39944@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJZ5v0hw1910Gsb57POVhax1hAbEGHa7xksr_FygNd_JL-oeOA@mail.gmail.com>

On Thu, May 29, 2025 at 11:38:05AM +0200, Rafael J. Wysocki wrote:

> First off, I'm not sure if all of the requisite things are ready then
> (sysfs etc.).

Pretty much everything is already running at early_initcall(). Sysfs
certainly is.

> We may end up doing this eventually, but it may not be straightforward.
> 
> More importantly, this is not a change for 6.15.y (y > 0).

Seriously, have you even tried? 

AFAICT the below is all that is needed.  That boots just fine on the one
randon system I tried, and seems to still work.

And this is plenty small enough to go into 6.15.y


diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 0835da449db8..0f25de8081af 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -814,4 +814,4 @@ static int __init cpuidle_init(void)
 
 module_param(off, int, 0444);
 module_param_string(governor, param_governor, CPUIDLE_NAME_LEN, 0444);
-core_initcall(cpuidle_init);
+early_initcall(cpuidle_init);

  reply	other threads:[~2025-05-30  8:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-28 12:53 [PATCH v1 0/2] x86/smp: Fix power regression introduced by commit 96040f7273e2 Rafael J. Wysocki
2025-05-28 12:53 ` [PATCH v1 1/2] Revert "x86/smp: Eliminate mwait_play_dead_cpuid_hint()" Rafael J. Wysocki
2025-05-28 12:54 ` [PATCH v1 2/2] x86/smp: Prefer cpuidle_play_dead() to mwait_play_dead_cpuid_hint() Rafael J. Wysocki
2025-05-28 13:17 ` [PATCH v1 0/2] x86/smp: Fix power regression introduced by commit 96040f7273e2 Peter Zijlstra
2025-05-28 13:20   ` Rafael J. Wysocki
2025-05-28 13:38     ` Peter Zijlstra
2025-05-28 14:25       ` Rafael J. Wysocki
2025-05-28 16:05         ` Peter Zijlstra
2025-05-28 17:09           ` Rafael J. Wysocki
2025-05-29  8:53             ` Peter Zijlstra
2025-05-29  9:38               ` Rafael J. Wysocki
2025-05-30  8:07                 ` Peter Zijlstra [this message]
2025-05-30  9:18                   ` Rafael J. Wysocki
2025-05-30  9:27                     ` Rafael J. Wysocki
2025-05-30 16:59                     ` Rafael J. Wysocki
2025-05-30 17:55                       ` Rafael J. Wysocki
2025-05-29 13:40 ` [PATCH v2] Revert "x86/smp: Eliminate mwait_play_dead_cpuid_hint()" Rafael J. Wysocki
2025-05-29 14:25   ` Dave Hansen
2025-05-29 15:39     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250530080733.GH39944@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=bp@suse.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=gautham.shenoy@amd.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=todd.e.brandt@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox