From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F255C25DCE3; Thu, 19 Jun 2025 07:43:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750319036; cv=none; b=tz5T7IbenViYMygnuOEhyDfZmMAiqdCNjmg3cTstwsx92LTmkKyHS/qxzEpAaYZgFF/XRH3lFRt3p5wGUZKXxCTg1c7pNTFpn6BJWbpg31DdAdnMcx9minoT7uU8fJPs6BhpwocpPuYI0Qa4EhOb0M7IZwoZSzalIGP/+4Qr9jw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750319036; c=relaxed/simple; bh=ioLmWy88Cgo8y1/dppgCwzSeNdVJKikPv5yV4IyE2h0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gD8mNf+rsP9TKKS4wqb5okQo6io7Y4nmKTRLcjEs0t7L+hWbvRPLBqSyYvzkY5Z6P0MYAN7W1TyUapLW8UZie36Ixh3hX+67k/e+2DM6P7ecColhpYel9KvC84KV87WqaguM+xJfSZMP7Mj3icwonj5FWGlbBbVhk+KGQTUaMCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LBhfQ6gA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LBhfQ6gA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2FC6C4CEED; Thu, 19 Jun 2025 07:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750319035; bh=ioLmWy88Cgo8y1/dppgCwzSeNdVJKikPv5yV4IyE2h0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LBhfQ6gAtLHVKJMVYXVbZqBCLyzlIiIbXyNdojS9bu8yozEEuA2HkWEwnJZgaEiZG k43Jv/ZSQ8GhGowyEcmfaU5dyui2PHnCVbzmJ3TJaFGLNb9bcbjNlFFktLyZm1lhbr j/LAwiquW0glJplpqvxy+33ZHeyPjv/uiHHoektSAo9rkiHjNKHMCcmqpHVGiZhGVO kJetFsf9+/uE9il1Jo/oA2P+tszjmjtIQrP/TDCxNS9hlJFwsOmXGSmH1flWCuKhsQ EQDON2KhZJ0Y5Y4e1So//1qkHqU8Ip3seD13AmbxKv4aP0esLnUWP1rO4+KNbLq1kM 3BdXpAU4LT8WA== Date: Thu, 19 Jun 2025 09:43:53 +0200 From: Krzysztof Kozlowski To: Michal Wilczynski Cc: Drew Fustini , Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Philipp Zabel , Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Ulf Hansson , Marek Szyprowski , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v5 2/8] dt-bindings: firmware: thead,th1520: Add resets for GPU clkgen Message-ID: <20250619-efficient-peccary-of-infinity-e9367f@kuoka> References: <20250618-apr_14_for_sending-v5-0-27ed33ea5c6f@samsung.com> <20250618-apr_14_for_sending-v5-2-27ed33ea5c6f@samsung.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250618-apr_14_for_sending-v5-2-27ed33ea5c6f@samsung.com> On Wed, Jun 18, 2025 at 12:22:08PM GMT, Michal Wilczynski wrote: > Extend the TH1520 AON to describe the GPU clkgen reset line, required > for proper GPU clock and reset sequencing. > > The T-HEAD TH1520 GPU requires coordinated management of two clocks > (core and sys) and two resets (GPU core reset and GPU clkgen reset). > Only the clkgen reset is exposed at the AON level, to support SoC > specific initialization handled through a dedicated auxiliary power > sequencing driver. The GPU core reset remains described in the GPU > device node, as from the GPU driver's perspective, there is only a > single reset line [1]. > > This follows upstream maintainers' recommendations [2] to abstract SoC > specific details into the PM domain layer rather than exposing them to > drivers directly. > > Link: https://lore.kernel.org/all/816db99d-7088-4c1a-af03-b9a825ac09dc@imgtec.com/ - [1] > Link: https://lore.kernel.org/all/38d9650fc11a674c8b689d6bab937acf@kernel.org/ - [2] > > Reviewed-by: Ulf Hansson > Signed-off-by: Michal Wilczynski Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof