From: Mateusz Majewski <m.majewski2@samsung.com>
To: linux.amoon@gmail.com
Cc: alim.akhtar@samsung.com, bzolnier@gmail.com,
daniel.lezcano@linaro.org, justinstitt@google.com,
krzk@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, llvm@lists.linux.dev,
lukasz.luba@arm.com, morbo@google.com, nathan@kernel.org,
nick.desaulniers+lkml@gmail.com, rafael@kernel.org,
rui.zhang@intel.com
Subject: Re: [PATCH v6 2/4] thermal/drivers/exynos: Use devm_clk_get_enabled() helpers
Date: Wed, 2 Jul 2025 14:00:15 +0200 [thread overview]
Message-ID: <20250702120015.350609-1-m.majewski2@samsung.com> (raw)
In-Reply-To: <20250430123306.15072-3-linux.amoon@gmail.com>
Hello :)
These:
> + data->clk = devm_clk_get_enabled(dev, "tmu_apbif");
> + data->clk_sec = devm_clk_get_enabled(dev, "tmu_triminfo_apbif");
should probably call devm_clk_get_prepared instead, as they are only
prepared inside current code:
> - ret = clk_prepare(data->clk);
> - ret = clk_prepare(data->clk_sec);
as elsewhere they are only enabled on use and then disabled. Only
data->sclk is enabled immediately:
> - ret = clk_prepare_enable(data->sclk);
Thank you,
Mateusz Majewski
next prev parent reply other threads:[~2025-07-02 12:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 12:32 [PATCH v6 0/4] Exynos Thermal code improvement Anand Moon
2025-04-30 12:32 ` [PATCH v6 1/4] thermal/drivers/exynos: Refactor clk_sec initialization inside SOC-specific case Anand Moon
2025-04-30 12:32 ` [PATCH v6 2/4] thermal/drivers/exynos: Use devm_clk_get_enabled() helpers Anand Moon
2025-07-02 12:00 ` Mateusz Majewski [this message]
2025-04-30 12:32 ` [PATCH v6 3/4] thermal/drivers/exynos: Remove redundant IS_ERR() checks for clk_sec clock Anand Moon
2025-04-30 12:33 ` [PATCH v6 4/4] thermal/drivers/exynos: Fixed the efuse min max value for exynos5422 Anand Moon
2025-05-08 6:14 ` [PATCH v6 0/4] Exynos Thermal code improvement Anand Moon
2025-05-08 6:26 ` Krzysztof Kozlowski
2025-05-08 11:36 ` Anand Moon
2025-05-14 11:23 ` Daniel Lezcano
2025-05-15 11:10 ` Anand Moon
2025-05-15 13:28 ` Daniel Lezcano
2025-05-15 18:01 ` Anand Moon
2025-05-16 14:45 ` Daniel Lezcano
2025-05-17 19:41 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250702120015.350609-1-m.majewski2@samsung.com \
--to=m.majewski2@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=bzolnier@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=justinstitt@google.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=llvm@lists.linux.dev \
--cc=lukasz.luba@arm.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox