From: Samuel Zhang <guoqing.zhang@amd.com>
To: <alexander.deucher@amd.com>, <christian.koenig@amd.com>,
<rafael@kernel.org>, <len.brown@intel.com>, <pavel@kernel.org>,
<gregkh@linuxfoundation.org>, <dakr@kernel.org>,
<airlied@gmail.com>, <simona@ffwll.ch>, <ray.huang@amd.com>,
<matthew.auld@intel.com>, <matthew.brost@intel.com>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>
Cc: <mario.limonciello@amd.com>, <lijo.lazar@amd.com>,
<victor.zhao@amd.com>, <haijun.chang@amd.com>, <Qing.Ma@amd.com>,
<Owen.Zhang2@amd.com>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <amd-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>,
"Samuel Zhang" <guoqing.zhang@amd.com>
Subject: [PATCH v6 4/5] PM: hibernate: add new api pm_hibernate_is_recovering()
Date: Thu, 10 Jul 2025 14:23:12 +0800 [thread overview]
Message-ID: <20250710062313.3226149-5-guoqing.zhang@amd.com> (raw)
In-Reply-To: <20250710062313.3226149-1-guoqing.zhang@amd.com>
dev_pm_ops.thaw() is called in following cases:
* normal case: after hibernation image has been created.
* error case 1: creation of a hibernation image has failed.
* error case 2: restoration from a hibernation image has failed.
For normal case, it is called mainly for resume storage devices for
saving the hibernation image. Other devices that are not involved
in the image saving do not need to resume the device. But since there's
no api to know which case thaw() is called, device drivers can't
conditionally resume device in thaw().
The new pm_hibernate_is_recovering() is such a api to query if thaw() is
called in normal case.
Signed-off-by: Samuel Zhang <guoqing.zhang@amd.com>
---
drivers/base/power/main.c | 14 ++++++++++++++
include/linux/suspend.h | 2 ++
2 files changed, 16 insertions(+)
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index 24ebe7a635a7..c4817b379230 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -66,6 +66,20 @@ static pm_message_t pm_transition;
static DEFINE_MUTEX(async_wip_mtx);
static int async_error;
+/**
+ * pm_hibernate_is_recovering - if recovering from hibernate due to error.
+ *
+ * Used to query if dev_pm_ops.thaw() is called for normal hibernation case or
+ * recovering from some error.
+ *
+ * Return: true for error case, false for normal case.
+ */
+bool pm_hibernate_is_recovering(void)
+{
+ return pm_transition.event == PM_EVENT_RECOVER;
+}
+EXPORT_SYMBOL_GPL(pm_hibernate_is_recovering);
+
static const char *pm_verb(int event)
{
switch (event) {
diff --git a/include/linux/suspend.h b/include/linux/suspend.h
index 6a3f92098872..d11a124b7a91 100644
--- a/include/linux/suspend.h
+++ b/include/linux/suspend.h
@@ -426,6 +426,8 @@ int is_hibernate_resume_dev(dev_t dev);
static inline int is_hibernate_resume_dev(dev_t dev) { return 0; }
#endif
+bool pm_hibernate_is_recovering(void);
+
/* Hibernation and suspend events */
#define PM_HIBERNATION_PREPARE 0x0001 /* Going to hibernate */
#define PM_POST_HIBERNATION 0x0002 /* Hibernation finished */
--
2.43.5
next prev parent reply other threads:[~2025-07-10 6:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 6:23 [PATCH v6 0/5] reduce system memory requirement for hibernation Samuel Zhang
2025-07-10 6:23 ` [PATCH v6 1/5] drm/ttm: add new api ttm_device_prepare_hibernation() Samuel Zhang
2025-07-10 6:23 ` [PATCH v6 2/5] drm/amdgpu: move GTT to shmem after eviction for hibernation Samuel Zhang
2025-07-10 6:23 ` [PATCH v6 3/5] PM: hibernate: shrink shmem pages after dev_pm_ops.prepare() Samuel Zhang
2025-07-10 6:23 ` Samuel Zhang [this message]
2025-07-10 8:21 ` [PATCH v6 4/5] PM: hibernate: add new api pm_hibernate_is_recovering() Rafael J. Wysocki
2025-07-10 6:23 ` [PATCH v6 5/5] drm/amdgpu: do not resume device in thaw for normal hibernation Samuel Zhang
2025-07-10 12:13 ` Mario Limonciello
2025-07-10 12:20 ` Christian König
2025-07-10 12:22 ` Mario Limonciello
2025-07-10 13:22 ` Lazar, Lijo
2025-07-10 15:57 ` [PATCH v6 0/5] reduce system memory requirement for hibernation Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710062313.3226149-5-guoqing.zhang@amd.com \
--to=guoqing.zhang@amd.com \
--cc=Owen.Zhang2@amd.com \
--cc=Qing.Ma@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=haijun.chang@amd.com \
--cc=len.brown@intel.com \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=victor.zhao@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox