linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] thermal: qcom: lmh: enable COMPILE_TEST testing
@ 2025-07-28 12:18 Dmitry Baryshkov
  2025-07-28 12:18 ` [PATCH v2 1/2] thermal: qcom: make LMH select QCOM_SCM Dmitry Baryshkov
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-07-28 12:18 UTC (permalink / raw)
  To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
	Zhang Rui, Lukasz Luba, Jackie Liu
  Cc: linux-arm-msm, linux-pm, linux-kernel, kernel test robot

Rework Kconfig dependencies and make LMH driver subject to the
COMPILE_TEST testing.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Changes in v2:
- Added missing includes (LKP)
- Link to v1: https://lore.kernel.org/r/20250725-lmh-scm-v1-1-84246981f435@oss.qualcomm.com

---
Dmitry Baryshkov (2):
      thermal: qcom: make LMH select QCOM_SCM
      thermal: qcom: lmh: add missing IRQ includes

 drivers/thermal/qcom/Kconfig | 3 ++-
 drivers/thermal/qcom/lmh.c   | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)
---
base-commit: a933d3dc1968fcfb0ab72879ec304b1971ed1b9a
change-id: 20250725-lmh-scm-5eca13e07a20

Best regards,
-- 
With best wishes
Dmitry


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/2] thermal: qcom: make LMH select QCOM_SCM
  2025-07-28 12:18 [PATCH v2 0/2] thermal: qcom: lmh: enable COMPILE_TEST testing Dmitry Baryshkov
@ 2025-07-28 12:18 ` Dmitry Baryshkov
  2025-07-28 12:18 ` [PATCH v2 2/2] thermal: qcom: lmh: add missing IRQ includes Dmitry Baryshkov
  2025-08-01 17:38 ` [PATCH v2 0/2] thermal: qcom: lmh: enable COMPILE_TEST testing Daniel Lezcano
  2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-07-28 12:18 UTC (permalink / raw)
  To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
	Zhang Rui, Lukasz Luba, Jackie Liu
  Cc: linux-arm-msm, linux-pm, linux-kernel

The QCOM_SCM symbol is not user-visible, so it makes little sense to
depend on it. Make LMH driver select QCOM_SCM as all other drivers do
and, as the dependecy is now correctly handled, enable || COMPILE_TEST
in order to include the driver into broader set of build tests.

Fixes: 9e5a4fb84230 ("thermal/drivers/qcom/lmh: make QCOM_LMH depends on QCOM_SCM")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 drivers/thermal/qcom/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/qcom/Kconfig b/drivers/thermal/qcom/Kconfig
index 2c7f3f9a26ebbba41b89c8aa5d310048e8d6c792..a6bb01082ec6978afb5df32464cf591e4670549e 100644
--- a/drivers/thermal/qcom/Kconfig
+++ b/drivers/thermal/qcom/Kconfig
@@ -34,7 +34,8 @@ config QCOM_SPMI_TEMP_ALARM
 
 config QCOM_LMH
 	tristate "Qualcomm Limits Management Hardware"
-	depends on ARCH_QCOM && QCOM_SCM
+	depends on ARCH_QCOM || COMPILE_TEST
+	select QCOM_SCM
 	help
 	  This enables initialization of Qualcomm limits management
 	  hardware(LMh). LMh allows for hardware-enforced mitigation for cpus based on

-- 
2.39.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] thermal: qcom: lmh: add missing IRQ includes
  2025-07-28 12:18 [PATCH v2 0/2] thermal: qcom: lmh: enable COMPILE_TEST testing Dmitry Baryshkov
  2025-07-28 12:18 ` [PATCH v2 1/2] thermal: qcom: make LMH select QCOM_SCM Dmitry Baryshkov
@ 2025-07-28 12:18 ` Dmitry Baryshkov
  2025-08-01 17:38 ` [PATCH v2 0/2] thermal: qcom: lmh: enable COMPILE_TEST testing Daniel Lezcano
  2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-07-28 12:18 UTC (permalink / raw)
  To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
	Zhang Rui, Lukasz Luba, Jackie Liu
  Cc: linux-arm-msm, linux-pm, linux-kernel, kernel test robot

As reported by LKP, the Qualcomm LMH driver needs to include several
IRQ-related headers, which decrlare necessary IRQ functionality.
Currently driver builds on ARM64 platforms, where the headers are pulled
in implicitly by other headers, but fails to build on other platforms.

Fixes: 53bca371cdf7 ("thermal/drivers/qcom: Add support for LMh driver")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507270042.KdK0KKht-lkp@intel.com/
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 drivers/thermal/qcom/lmh.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/thermal/qcom/lmh.c b/drivers/thermal/qcom/lmh.c
index 75eaa9a68ab8aad7f7dcb575b3ea34b9a12a0dbf..c681a3c89ffa0b9aa0713d6db45f444cb79bcf03 100644
--- a/drivers/thermal/qcom/lmh.c
+++ b/drivers/thermal/qcom/lmh.c
@@ -5,6 +5,8 @@
  */
 #include <linux/module.h>
 #include <linux/interrupt.h>
+#include <linux/irq.h>
+#include <linux/irqdesc.h>
 #include <linux/irqdomain.h>
 #include <linux/err.h>
 #include <linux/platform_device.h>

-- 
2.39.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/2] thermal: qcom: lmh: enable COMPILE_TEST testing
  2025-07-28 12:18 [PATCH v2 0/2] thermal: qcom: lmh: enable COMPILE_TEST testing Dmitry Baryshkov
  2025-07-28 12:18 ` [PATCH v2 1/2] thermal: qcom: make LMH select QCOM_SCM Dmitry Baryshkov
  2025-07-28 12:18 ` [PATCH v2 2/2] thermal: qcom: lmh: add missing IRQ includes Dmitry Baryshkov
@ 2025-08-01 17:38 ` Daniel Lezcano
  2 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2025-08-01 17:38 UTC (permalink / raw)
  To: Dmitry Baryshkov, Amit Kucheria, Thara Gopinath,
	Rafael J. Wysocki, Zhang Rui, Lukasz Luba, Jackie Liu
  Cc: linux-arm-msm, linux-pm, linux-kernel, kernel test robot

On 28/07/2025 14:18, Dmitry Baryshkov wrote:
> Rework Kconfig dependencies and make LMH driver subject to the
> COMPILE_TEST testing.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---

Applied, thanks

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-08-01 17:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-28 12:18 [PATCH v2 0/2] thermal: qcom: lmh: enable COMPILE_TEST testing Dmitry Baryshkov
2025-07-28 12:18 ` [PATCH v2 1/2] thermal: qcom: make LMH select QCOM_SCM Dmitry Baryshkov
2025-07-28 12:18 ` [PATCH v2 2/2] thermal: qcom: lmh: add missing IRQ includes Dmitry Baryshkov
2025-08-01 17:38 ` [PATCH v2 0/2] thermal: qcom: lmh: enable COMPILE_TEST testing Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).