From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Samuel Wu <wusamuel@google.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Pavel Machek <pavel@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Saravana Kannan <saravanak@google.com>,
kernel-team@android.com,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] PM: Support aborting suspend during filesystem sync
Date: Wed, 13 Aug 2025 07:53:32 +0200 [thread overview]
Message-ID: <2025081359-survey-sprinkled-e6dc@gregkh> (raw)
In-Reply-To: <20250812232126.1814253-1-wusamuel@google.com>
On Tue, Aug 12, 2025 at 04:21:23PM -0700, Samuel Wu wrote:
> +static bool suspend_fs_sync_queued;
> +DEFINE_SPINLOCK(suspend_fs_sync_lock);
> +DECLARE_COMPLETION(suspend_fs_sync_complete);
> +void suspend_abort_fs_sync(void)
> +{
> + spin_lock(&suspend_fs_sync_lock);
> + complete(&suspend_fs_sync_complete);
> + spin_unlock(&suspend_fs_sync_lock);
> +}
Why no documentation for this public function that you added, but yet
you added documentation for a static function that no one can call?
thanks,
greg k-h
next prev parent reply other threads:[~2025-08-13 5:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 23:21 [PATCH v1] PM: Support aborting suspend during filesystem sync Samuel Wu
2025-08-13 5:53 ` Greg Kroah-Hartman [this message]
2025-08-15 0:49 ` Samuel Wu
2025-08-13 19:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025081359-survey-sprinkled-e6dc@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bsegall@google.com \
--cc=dakr@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@android.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=pavel@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=saravanak@google.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
--cc=wusamuel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox