From: Viresh Kumar <viresh.kumar@linaro.org>
To: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Cc: "Marek Szyprowski" <m.szyprowski@samsung.com>,
"Viresh Kumar" <vireshk@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
devicetree@vger.kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Nishanth Menon" <nm@ti.com>, "Stephen Boyd" <sboyd@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>
Subject: Re: [PATCH v4 2/7] OPP: Move refcount and key update for readability in _opp_table_find_key()
Date: Tue, 26 Aug 2025 11:40:51 +0530 [thread overview]
Message-ID: <20250826061051.bofm7bxiqviuhux2@vireshk-i7> (raw)
In-Reply-To: <919ea7ce-a36a-4eaa-a13a-c693eb9c6c2f@oss.qualcomm.com>
On 25-08-25, 21:26, Krishna Chaitanya Chundru wrote:
> looks like for compare_floor we need to iterate to the OPP table till
> the OPP key is greater than the target key and return previous OPP.
It depends on what kind of comparison we need to do. And this this is
how it works for the _floor variants. But we don't always return the
previous OPP. `compare` directly updates the `opp` and so it can be
currently iterated one too.
> In that case the updation of the key and dev_pm_opp_get() should be
> outside as before. We need to remove this part of the patch.
I think all we need to do here is check if an error is there or not,
maybe I am misreading it.
--
viresh
next prev parent reply other threads:[~2025-08-26 6:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 8:28 [PATCH v4 0/7] OPP: Add support to find OPP for a set of keys Krishna Chaitanya Chundru
2025-08-20 8:28 ` [PATCH v4 1/7] " Krishna Chaitanya Chundru
2025-08-22 6:50 ` Viresh Kumar
2025-08-20 8:28 ` [PATCH v4 2/7] OPP: Move refcount and key update for readability in _opp_table_find_key() Krishna Chaitanya Chundru
2025-08-22 6:51 ` Viresh Kumar
[not found] ` <CGME20250825135939eucas1p206b6e2b5ba115f51618c773a1f37939c@eucas1p2.samsung.com>
2025-08-25 13:59 ` Marek Szyprowski
2025-08-25 15:56 ` Krishna Chaitanya Chundru
2025-08-26 6:10 ` Viresh Kumar [this message]
2025-08-26 6:06 ` Viresh Kumar
2025-08-26 7:26 ` Marek Szyprowski
2025-08-26 8:24 ` Viresh Kumar
2025-08-26 11:25 ` Krzysztof Kozlowski
2025-08-20 8:28 ` [PATCH v4 3/7] arm64: dts: qcom: sm8450: Add opp-level to indicate PCIe data rates Krishna Chaitanya Chundru
2025-08-26 5:57 ` Manivannan Sadhasivam
2025-08-26 6:08 ` Manivannan Sadhasivam
2025-08-20 8:28 ` [PATCH v4 4/7] arm64: dts: qcom: sm8550: " Krishna Chaitanya Chundru
2025-08-20 8:28 ` [PATCH v4 5/7] arm64: dts: qcom: sm8650: " Krishna Chaitanya Chundru
2025-08-20 8:28 ` [PATCH v4 6/7] arm64: dts: qcom: x1e80100: " Krishna Chaitanya Chundru
2025-08-20 8:28 ` [PATCH v4 7/7] PCI: qcom: Use frequency and level based OPP lookup Krishna Chaitanya Chundru
2025-08-20 8:55 ` Neil Armstrong
2025-08-26 5:54 ` Manivannan Sadhasivam
2025-08-25 16:44 ` [PATCH v4 0/7] OPP: Add support to find OPP for a set of keys Wasim Nazir
2025-08-26 5:20 ` Viresh Kumar
2025-08-26 5:36 ` Viresh Kumar
2025-08-26 8:27 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826061051.bofm7bxiqviuhux2@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mani@kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).